-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Look&Feel] Custom Panels Density and Consistency Improvements #2074
Merged
TackAdam
merged 2 commits into
opensearch-project:main
from
danieldong51:l&f-dashboards
Aug 22, 2024
Merged
[Look&Feel] Custom Panels Density and Consistency Improvements #2074
TackAdam
merged 2 commits into
opensearch-project:main
from
danieldong51:l&f-dashboards
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldong51
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
August 19, 2024 23:31
TackAdam
approved these changes
Aug 20, 2024
derek-ho
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Signed-off-by: Dan Dong <[email protected]>
danieldong51
force-pushed
the
l&f-dashboards
branch
from
August 20, 2024 17:58
5581cca
to
6e7d30e
Compare
virajsanghvi
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm, although probably need to validate failing checks
Swiddis
approved these changes
Aug 20, 2024
Signed-off-by: Dan Dong <[email protected]>
danieldong51
force-pushed
the
l&f-dashboards
branch
from
August 21, 2024 23:28
93a4101
to
0780a07
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Look&Feel for Dashboards Signed-off-by: Dan Dong <[email protected]> * Fixed lint errors Signed-off-by: Dan Dong <[email protected]> --------- Signed-off-by: Dan Dong <[email protected]> (cherry picked from commit cdf57bd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
pushed a commit
that referenced
this pull request
Aug 22, 2024
#2089) * Look&Feel for Dashboards * Fixed lint errors --------- (cherry picked from commit cdf57bd) Signed-off-by: Dan Dong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the Look & Feel density and consistency changes to the Observability Custom Panels Folder:
Screenshots
Small context Menu
Semantic Headers
Flyouts
Modals
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.