Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Look&Feel] Custom Panels Density and Consistency Improvements #2074

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

danieldong51
Copy link
Contributor

@danieldong51 danieldong51 commented Aug 19, 2024

Description

This PR applies the Look & Feel density and consistency changes to the Observability Custom Panels Folder:

  1. Use small context menus
  2. Use small tabs
  3. Standardize paragraph size (15.75px next theme / 14px V7 theme)
  4. Use semantic headers (H1s on main pages, H2s on modals/flyouts)
  5. Modal/Flyout Typography
  6. Buttons for actions, only using primary buttons for primary calls to action
  7. Use small padding on popovers

Screenshots

Small context Menu

Scope Before After
Dashboards: Overview Actions Dashboards Actions Before Dashboards Post
Dashboards: Actions Dashboards SO Actions Before Dashboards SO Actions Post
Dashboards: Vis Actions Dashboards Vis Actions Before Dashboards Vis Actions Post
Dashboards: Vis Dashboards Vis Before Dashboards Vis Post

Semantic Headers

Scope Before After
Dashboard: Overview Dashboards Before Dashboards Post
Dashboard: Title Dashboard Before Dashboard Post

Flyouts

Scope Before After
Dashboard: Select Vis Dashboards Select Vis Before Dashboards Select Vis Post

Modals

Scope Before After
Dashboard: Create Dashboards Create Before Dashboards Create Post
Dashboard: Error Dashboard Error Header Before Dashboard Error Header Post
Dashboard: Error Dashboard Error p Before Dashboard Error P Post
Dashboard: Samples Dashboard Samples Before Dashboard Samples Post

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, although probably need to validate failing checks

Signed-off-by: Dan Dong <[email protected]>
@TackAdam TackAdam merged commit cdf57bd into opensearch-project:main Aug 22, 2024
12 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 22, 2024
* Look&Feel for Dashboards

Signed-off-by: Dan Dong <[email protected]>

* Fixed lint errors

Signed-off-by: Dan Dong <[email protected]>

---------

Signed-off-by: Dan Dong <[email protected]>
(cherry picked from commit cdf57bd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam pushed a commit that referenced this pull request Aug 22, 2024
#2089)

* Look&Feel for Dashboards



* Fixed lint errors



---------


(cherry picked from commit cdf57bd)

Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants