Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Look&Feel] Integrations Density and Consistency Improvements #2071

Merged
merged 5 commits into from
Aug 21, 2024
Merged

[Look&Feel] Integrations Density and Consistency Improvements #2071

merged 5 commits into from
Aug 21, 2024

Conversation

danieldong51
Copy link
Contributor

@danieldong51 danieldong51 commented Aug 19, 2024 •
edited
Loading

Description

This PR applies the Look & Feel density and consistency changes to the Integrations folder:

  1. Use small context menus
  2. Use small tabs
  3. Standardize paragraph size (15.75px next theme / 14px V7 theme)
  4. Use semantic headers (H1s on main pages, H2s on modals/flyouts)
  5. Modal/Flyout Typography
  6. Buttons for actions, only using primary buttons for primary calls to action
  7. Use small padding on popovers

Screenshots

Small context Menu

Scope Before After
Integrations Integration Home context menu before Integration Home context menu post

Small tabs

Scope Before After
Integration: Home Integration Home before Integration Home post
Integration: Details Integration Tab before Integration Tab post

Paragraph size

Scope Before After
Integration: Details Integration Details P Before Integration Details P Post

Semantic Headers

Scope Before After
Integrations: Overview Integration Overview Header Before Integration Overview Header Post
Integrations: Header Integration Header Before Integration Header Post
Integrations: Setup Integration Set up before Integration Set up post
Integrations: Added Integrations Added title before Integrations Added title post

Flyouts and Modals

Scope Before After
Integrations: Upload Integration Upload Before Integration Upload Post
Integrations: Delete Integration Delete Header Before Integration Delete Header Post
Integrations: Delete Integration Delete p Before Integration Delete p Post

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@danieldong51 danieldong51 marked this pull request as ready for review August 19, 2024 23:31
derek-ho
derek-ho approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@danieldong51
Merged Main
ba2a19b 
Signed-off-by: Dan Dong <[email protected]>
@danieldong51
Reverted change
8e0ee49 
Signed-off-by: Dan Dong <[email protected]>
@danieldong51
Fixed error
42d92c5 
Signed-off-by: Dan Dong <[email protected]>
@danieldong51
Updated snapshot testing
9b2c2a9 
Signed-off-by: Dan Dong <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.75%. Comparing base (c3ab50f) to head (0a629db).
Report is 58 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
- Coverage   57.85%   54.75%   -3.10%     
==========================================
  Files         372      394      +22     
  Lines       14081    15244    +1163     
  Branches     3712     4124     +412     
==========================================
+ Hits         8146     8347     +201     
- Misses       5871     6816     +945     
- Partials       64       81      +17
Flag Coverage Δ
dashboards-observability 54.75% <100.00%> (-3.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

virajsanghvi
virajsanghvi approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm

@TackAdam TackAdam added enhancement New feature or request backport 2.x labels Aug 21, 2024
@danieldong51
Fix lint errors
0a629db 
Signed-off-by: Dan Dong <[email protected]>
@TackAdam TackAdam merged commit 7cdcacb into opensearch-project:main Aug 21, 2024
12 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 21, 2024
@github-actions
[Look&Feel] Integrations Density and Consistency Improvements (#2071)
c03ee23 
* Merged Main

Signed-off-by: Dan Dong <[email protected]>

* Reverted change

Signed-off-by: Dan Dong <[email protected]>

* Fixed error

Signed-off-by: Dan Dong <[email protected]>

* Updated snapshot testing

Signed-off-by: Dan Dong <[email protected]>

* Fix lint errors

Signed-off-by: Dan Dong <[email protected]>

---------

Signed-off-by: Dan Dong <[email protected]>
(cherry picked from commit 7cdcacb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 21, 2024
Merged
TackAdam pushed a commit that referenced this pull request Aug 22, 2024
@opensearch-trigger-bot @github-actions
[Look&Feel] Integrations Density and Consistency Improvements (#2071) (…
2d80408 
…#2083)

* Merged Main



* Reverted change



* Fixed error



* Updated snapshot testing



* Fix lint errors



---------


(cherry picked from commit 7cdcacb)

Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TackAdam TackAdam TackAdam approved these changes

@Swiddis Swiddis Swiddis approved these changes

@derek-ho derek-ho derek-ho approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@ps48 ps48 Awaiting requested review from ps48

@kavithacm kavithacm Awaiting requested review from kavithacm

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@dai-chen dai-chen Awaiting requested review from dai-chen

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@penghuo penghuo Awaiting requested review from penghuo

@seankao-az seankao-az Awaiting requested review from seankao-az

@anirudha anirudha Awaiting requested review from anirudha

@paulstn paulstn Awaiting requested review from paulstn

@sumukhswamy sumukhswamy Awaiting requested review from sumukhswamy

Assignees
No one assigned
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danieldong51 @virajsanghvi @derek-ho @Swiddis @TackAdam