[Feature] Multi-data Source Support for Getting Started #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2024 11:33
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
ps48
reviewed
Aug 9, 2024
ps48
reviewed
Aug 9, 2024
ps48
reviewed
Aug 9, 2024
ps48
reviewed
Aug 9, 2024
Signed-off-by: Adam Tackett <[email protected]>
TackAdam
commented
Aug 9, 2024
| const loadedObjects = await objects.toArray(); | ||
|
|
||
| const updatedObjects = loadedObjects.map((obj) => { | ||
| if (mdsId) { |
There was a problem hiding this comment.
Now renames with the convention mds-(mdsId)-objectId-(originalId) to clearly distinguish the created assets.
Sticks to the original behavior if mds is not enabled of just creating it under its original Id.
TackAdam
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
YANG-DB
approved these changes
Aug 12, 2024
Signed-off-by: Adam Tackett <[email protected]>
ps48
reviewed
Aug 14, 2024
ps48
reviewed
Aug 14, 2024
ps48
reviewed
Aug 14, 2024
Comment on lines
171
to
175
| newReferences.push({ | ||
| id: mdsId, | ||
| type: 'data-source', | ||
| name: mdsLabel, | ||
| }); |
There was a problem hiding this comment.
Can you please validate with @sumukhswamy if references are needed for all the created saved objects. IIRC it is only needed for index patterns. Since, visualizations have a reference to index pattern and dashboards have a reference to visualizations we can infer the original datasource by tracking other references.
There was a problem hiding this comment.
After meeting with Sumukh only the index-pattern will have the added reference. The otheres will just get the updated ID's
Signed-off-by: Adam Tackett <[email protected]>
ps48
approved these changes
Aug 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
* first step of MDS Signed-off-by: Adam Tackett <[email protected]> * add mds support to getting started Signed-off-by: Adam Tackett <[email protected]> * update references, renaming, code cleanup Signed-off-by: Adam Tackett <[email protected]> * update snapshots, remove depend Signed-off-by: Adam Tackett <[email protected]> * only add mds reference to index patterns Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 359cdf9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
to sumukhswamy/dashboards-observability
that referenced
this pull request
Aug 19, 2024
…roject#2048) * first step of MDS Signed-off-by: Adam Tackett <[email protected]> * add mds support to getting started Signed-off-by: Adam Tackett <[email protected]> * update references, renaming, code cleanup Signed-off-by: Adam Tackett <[email protected]> * update snapshots, remove depend Signed-off-by: Adam Tackett <[email protected]> * only add mds reference to index patterns Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> Signed-off-by: sumukhswamy <[email protected]>
TackAdam
added a commit
to TackAdam/dashboards-observability
that referenced
this pull request
Aug 20, 2024
…roject#2048) * first step of MDS Signed-off-by: Adam Tackett <[email protected]> * add mds support to getting started Signed-off-by: Adam Tackett <[email protected]> * update references, renaming, code cleanup Signed-off-by: Adam Tackett <[email protected]> * update snapshots, remove depend Signed-off-by: Adam Tackett <[email protected]> * only add mds reference to index patterns Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> Signed-off-by: Adam Tackett <[email protected]>
TackAdam
pushed a commit
that referenced
this pull request
Aug 22, 2024
* first step of MDS * add mds support to getting started * update references, renaming, code cleanup * update snapshots, remove depend * only add mds reference to index patterns --------- (cherry picked from commit 359cdf9) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables multi-data source support to getting started.
Adjust the "Create Asset" button to pre-pend the MDS id and update the reference field to include mdsId and mdsLabel.
Screen.Recording.2024-08-08.at.4.32.57.PM.mov
MDS dashboard url:
Local cluster dashboard url:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.