[Bug] Trace Analytics bugfix for breadcrumbs and id pathing #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
ps48
reviewed
Aug 2, 2024
public/components/trace_analytics/components/services/service_view.tsx
Outdated
Show resolved
Hide resolved
ps48
reviewed
Aug 2, 2024
public/components/trace_analytics/components/traces/trace_view.tsx
Outdated
Show resolved
Hide resolved
ps48
reviewed
Aug 2, 2024
| @@ -123,7 +123,7 @@ export const Home = (props: HomeProps) => { | |||
| let defaultRoute = props.defaultRoute ?? '/services'; | |||
| const currentHash = window.location.hash.split('#')[1] || ''; | |||
|
|
|||
| if (currentHash === '/traces' || currentHash === '/services') { | |||
| if (currentHash.startsWith('/traces') || currentHash.startsWith('/services')) { | |||
added 2 commits
August 2, 2024 15:05
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
TackAdam
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
6 tasks
ps48
approved these changes
Aug 2, 2024
YANG-DB
approved these changes
Aug 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
* bugfix ids and breadcrumbs Signed-off-by: Adam Tackett <[email protected]> * remove comments Signed-off-by: Adam Tackett <[email protected]> * quick fix Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit faf2207) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
* bugfix ids and breadcrumbs Signed-off-by: Adam Tackett <[email protected]> * remove comments Signed-off-by: Adam Tackett <[email protected]> * quick fix Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit faf2207) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Aug 3, 2024
…2040) * bugfix ids and breadcrumbs * remove comments * quick fix --------- (cherry picked from commit faf2207) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
TackAdam
added a commit
to TackAdam/dashboards-observability
that referenced
this pull request
Aug 20, 2024
…ch-project#2037) * bugfix ids and breadcrumbs Signed-off-by: Adam Tackett <[email protected]> * remove comments Signed-off-by: Adam Tackett <[email protected]> * quick fix Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> Signed-off-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trace Analytics bug fix for breadcrumbs and id pathing
Old Navigation after change:
Screen.Recording.2024-08-02.at.3.50.25.PM.mov
New navigation after change:
NewNavFix.mov
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.