Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix CVEs for ag-grid, ws and braces packages #1987

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Jul 24, 2024

Description

Update the following dependencies:
"@ag-grid-community/styles": "^31.2.0" bump to "^32.0.2"
"ag-grid-react": "^31.2.0" bump to "^32.0.2"

Resolutions added:
"braces": "^3.0.3"
"ws": "^8.18.0"

Issues Resolved

CVE-2024-39001
CVE-2024-37890
CVE-2024-39001

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Adam Tackett added 2 commits July 24, 2024 11:43
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you list the CVEs this remediates?

@derek-ho
Copy link
Collaborator

Should this be backported ot 2.16?

@ps48 ps48 changed the title [Bug] Fix CVEs [Bug] Fix CVEs for ag-grid, ws and braces packages Jul 24, 2024
@ps48 ps48 merged commit faf0903 into opensearch-project:main Jul 24, 2024
8 of 26 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1987-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faf090370bf3512704bf43dff9bc43f6de6458f2
# Push it to GitHub
git push --set-upstream origin backport/backport-1987-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1987-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.16
# Create a new branch
git switch --create backport/backport-1987-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faf090370bf3512704bf43dff9bc43f6de6458f2
# Push it to GitHub
git push --set-upstream origin backport/backport-1987-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-1987-to-2.16.

ps48 added a commit that referenced this pull request Jul 24, 2024
@TackAdam
Copy link
Collaborator Author

Backports to 2.x and 2.16 handled with:
#1990
#1991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants