Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few bugs with respect to refreshes and mode set via session sto… #197

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

derek-ho
Copy link
Collaborator

…rage

Signed-off-by: Derek Ho [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho derek-ho marked this pull request as ready for review February 1, 2023 15:34
@derek-ho derek-ho requested a review from a team as a code owner February 1, 2023 15:34
@ps48
Copy link
Member

ps48 commented Feb 1, 2023

@derek-ho are we still pushing this to 2.5?

@derek-ho
Copy link
Collaborator Author

derek-ho commented Feb 1, 2023

@derek-ho are we still pushing this to 2.5?

@ps48 I was thinking to push it in here and backport to 2.x and main in case we need to release 2.5.1, etc.

@derek-ho derek-ho merged commit 37421ba into opensearch-project:2.5 Feb 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 1, 2023
#197)

* fix a few bugs with respect to refreshes and mode set via session storage

Signed-off-by: Derek Ho <[email protected]>

* fix tests related to the change

Signed-off-by: Derek Ho <[email protected]>

* pr fixes

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 37421ba)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 1, 2023
#197)

* fix a few bugs with respect to refreshes and mode set via session storage

Signed-off-by: Derek Ho <[email protected]>

* fix tests related to the change

Signed-off-by: Derek Ho <[email protected]>

* pr fixes

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 37421ba)
derek-ho added a commit that referenced this pull request Feb 6, 2023
#197) (#238)

* fix a few bugs with respect to refreshes and mode set via session storage

Signed-off-by: Derek Ho <[email protected]>

* fix tests related to the change

Signed-off-by: Derek Ho <[email protected]>

* pr fixes

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 37421ba)

Co-authored-by: Derek Ho <[email protected]>
derek-ho added a commit that referenced this pull request Feb 6, 2023
#197) (#237)

* fix a few bugs with respect to refreshes and mode set via session storage

Signed-off-by: Derek Ho <[email protected]>

* fix tests related to the change

Signed-off-by: Derek Ho <[email protected]>

* pr fixes

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 37421ba)

Co-authored-by: Derek Ho <[email protected]>
derek-ho added a commit to derek-ho/dashboards-observability that referenced this pull request Feb 23, 2023
opensearch-project#197) (opensearch-project#237)

* fix a few bugs with respect to refreshes and mode set via session storage

Signed-off-by: Derek Ho <[email protected]>

* fix tests related to the change

Signed-off-by: Derek Ho <[email protected]>

* pr fixes

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 37421ba)

Co-authored-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
pjfitzgibbons pushed a commit that referenced this pull request Mar 28, 2023
#197) (#237)

* fix a few bugs with respect to refreshes and mode set via session storage

Signed-off-by: Derek Ho <[email protected]>

* fix tests related to the change

Signed-off-by: Derek Ho <[email protected]>

* pr fixes

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 37421ba)

Co-authored-by: Derek Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants