-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a few bugs with respect to refreshes and mode set via session sto… #197
Merged
derek-ho
merged 3 commits into
opensearch-project:2.5
from
derek-ho:traces-2.5-bug-fixes
Feb 1, 2023
Merged
fix a few bugs with respect to refreshes and mode set via session sto… #197
derek-ho
merged 3 commits into
opensearch-project:2.5
from
derek-ho:traces-2.5-bug-fixes
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
ps48
approved these changes
Feb 1, 2023
@derek-ho are we still pushing this to 2.5? |
joshuali925
approved these changes
Feb 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
#197) * fix a few bugs with respect to refreshes and mode set via session storage Signed-off-by: Derek Ho <[email protected]> * fix tests related to the change Signed-off-by: Derek Ho <[email protected]> * pr fixes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 37421ba)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
#197) * fix a few bugs with respect to refreshes and mode set via session storage Signed-off-by: Derek Ho <[email protected]> * fix tests related to the change Signed-off-by: Derek Ho <[email protected]> * pr fixes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 37421ba)
derek-ho
added a commit
that referenced
this pull request
Feb 6, 2023
#197) (#238) * fix a few bugs with respect to refreshes and mode set via session storage Signed-off-by: Derek Ho <[email protected]> * fix tests related to the change Signed-off-by: Derek Ho <[email protected]> * pr fixes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 37421ba) Co-authored-by: Derek Ho <[email protected]>
derek-ho
added a commit
that referenced
this pull request
Feb 6, 2023
#197) (#237) * fix a few bugs with respect to refreshes and mode set via session storage Signed-off-by: Derek Ho <[email protected]> * fix tests related to the change Signed-off-by: Derek Ho <[email protected]> * pr fixes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 37421ba) Co-authored-by: Derek Ho <[email protected]>
derek-ho
added a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Feb 23, 2023
opensearch-project#197) (opensearch-project#237) * fix a few bugs with respect to refreshes and mode set via session storage Signed-off-by: Derek Ho <[email protected]> * fix tests related to the change Signed-off-by: Derek Ho <[email protected]> * pr fixes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 37421ba) Co-authored-by: Derek Ho <[email protected]> Signed-off-by: Derek Ho <[email protected]>
pjfitzgibbons
pushed a commit
that referenced
this pull request
Mar 28, 2023
#197) (#237) * fix a few bugs with respect to refreshes and mode set via session storage Signed-off-by: Derek Ho <[email protected]> * fix tests related to the change Signed-off-by: Derek Ho <[email protected]> * pr fixes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 37421ba) Co-authored-by: Derek Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rage
Signed-off-by: Derek Ho [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.