Remove auto refresh option in create acceleration flyout #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
mengweieric
approved these changes
Apr 18, 2024
| return refreshType === 'autoInterval' && refreshWindow < 1 | ||
| ? ['refresh window should be greater than 0'] | ||
| : []; | ||
| if (refreshType === 'autoInterval' && refreshInterval === 'minute' && refreshWindow < 15) |
There was a problem hiding this comment.
Is it possible to have decimal numbers? like 0.1 hour?
There was a problem hiding this comment.
we use parse int to refresh window doesn't take decimal inputs
RyanL1997
approved these changes
Apr 18, 2024
Signed-off-by: Shenoy Pratik <[email protected]>
vmmusings
approved these changes
Apr 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* remove auto refresh option, update tests Signed-off-by: Shenoy Pratik <[email protected]> * update error on blur Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 1f7ee0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Apr 18, 2024
* remove auto refresh option, update tests * update error on blur --------- (cherry picked from commit 1f7ee0a) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…ver from public folder (opensearch-project#1705) (opensearch-project#1716) Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Yulong Ruan <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…project#1716) (opensearch-project#1718) * remove auto refresh option, update tests * update error on blur --------- (cherry picked from commit 1f7ee0a) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit f1e2ce1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove auto refresh option, update tests
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.