-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new page/route for notebooks create and rename #152
Merged
+99
−35
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
015d929
initial commit to get new page rendered for notebook create
derek-ho 8a7b4d1
clean up and new file for create
derek-ho 5b388fc
get breadcrumb working and page styling
derek-ho ad615c3
pushing work
derek-ho 6152d33
get it mainly working
derek-ho 7682fc9
fix existing test
derek-ho 613496a
clean up code and include two trivial tests
derek-ho c9e610a
push work
derek-ho 6dd53cd
remove clone for now
derek-ho 28bc0bc
fix component
derek-ho c4ceca5
update a test
derek-ho 6355fbe
add test for create
derek-ho fe62059
fix cypress test
derek-ho 05f5a80
PR comment fixes
derek-ho b47634b
fix test
derek-ho 7f89652
fix up
derek-ho d45370a
clean up
derek-ho 70b6253
revert integration test changes
derek-ho d6e8f87
fix test
derek-ho da2769e
fix test
derek-ho cc0763c
PR comments
derek-ho e9eabb7
fix test
derek-ho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derek-ho FYI future code changes (don't address for this PR)
Array.at(-1) vs arr[arr.length - 1]
The usual practice is to access length and calculate the index from that — for example, array[array.length - 1]. The at() method allows relative indexing, so this can be shortened to array.at(-1).