-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traces jaeger #150
Merged
Merged
Traces jaeger #150
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
97c12d6
get traces page working with queries
derek-ho 5fcb2ca
get trace individual page partially working
derek-ho 71ac297
get service page working initially
derek-ho 8bf4747
get services page mainly working
derek-ho c361298
get most things working except for dashboards
derek-ho d79bc9c
something is broken
derek-ho 29b8552
get time working on traces query
derek-ho 7bf6374
last commit for today
derek-ho 75fd5f5
done for today for real
derek-ho 0d6a4be
fix date filter
derek-ho 58d1088
trying to fix span table
derek-ho 5abd7d3
save work
derek-ho 5a99cb4
mostly fix trace page
derek-ho 2cb7d9f
services working and traces working
derek-ho 555319b
fix some more stuff
derek-ho b848af9
fix error shown on span detail chart
derek-ho 283fd1d
fix
derek-ho 041d38f
make general
derek-ho 676f082
make everything more general and get traces and services top level pa…
derek-ho 58a3a0e
get subpages working and get rid of servicemap when in jaeger mode
derek-ho a3d87ec
make most work on both
derek-ho fc6bbd7
pushing work
derek-ho 6750c6f
fix service map for data prepper
derek-ho 7237845
get more things to work
derek-ho 1e7bad3
push work
derek-ho 08a0bff
get almost everything working
derek-ho 0742d80
everything on parity - new features and UX fixes only needed from her…
derek-ho 81d3abf
fix service flyout pannel
derek-ho 9ec8533
fix app analytics
derek-ho 5dba245
default to data prepper for app analytics
derek-ho cabf24f
try to fix failing tests
derek-ho 3342e38
try to fix some more syntax and test issues
derek-ho 4728600
fix a few more things
derek-ho 3ee2db8
replace with union
derek-ho 128d0b5
fix a few more tests
derek-ho b94c935
all test pass!
derek-ho ccdae0f
try to get mode picker
derek-ho 76ae15a
get it hooked up - still need to iron out a few things
derek-ho cf43a6a
get it working
derek-ho 72b0a73
fix a few things
derek-ho 46dc547
some more work to get plots in
derek-ho 2189386
fix filters
derek-ho 8aa676b
add code to get to demo point
derek-ho 5e4fbe8
implement toggle on dashboard
derek-ho 440ea14
remove package lock
derek-ho 03e25a1
fix everything and get ui working well
derek-ho 90bde2f
add lisence headers and remove imports and unecessary mode type
derek-ho 324e000
run prettier
derek-ho 2321b24
add it to all pages
derek-ho cce6504
some pr fixes
derek-ho 390e77f
pushing work
derek-ho 2e15987
fix UX navigation final
derek-ho f8711bb
move service map call into data prepper mode only
derek-ho ba9c898
fix tests
derek-ho 5c6091c
fix gantt chart
derek-ho c5504ca
add tests
derek-ho d637471
add integration with event analytics
derek-ho 1812f83
guards
derek-ho f98c516
pushing up changes to queries
derek-ho 9624733
fix tests
derek-ho f3a871f
pr comments
derek-ho 57cd03f
add timeout
derek-ho ab65109
revert version
derek-ho 5f7dbe2
fix timeout
derek-ho 4a06925
test fixes and message fix
derek-ho 3dd96c5
fix toast into a single one
derek-ho 45cdc1e
address pr comments
derek-ho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ interface props { | |
} | ||
|
||
export const TraceBlock = ({ http, hit, logTraceId }: props) => { | ||
if (logTraceId === '' || !isValidTraceId(logTraceId)) { | ||
if ((!hit.traceID || hit.traceID.length === 0) && (logTraceId === '' || !isValidTraceId(logTraceId))){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. curious why changing it to check |
||
return ( | ||
<> | ||
<EuiCallOut iconType="help" title="No Trace Id found in the event."> | ||
|
@@ -42,6 +42,7 @@ export const TraceBlock = ({ http, hit, logTraceId }: props) => { | |
</> | ||
); | ||
} | ||
const mode = (!hit.traceID || hit.traceID.length === 0) ? 'data_prepper' : 'jaeger' | ||
|
||
return <TraceDetailRender traceId={logTraceId} http={http} />; | ||
return <TraceDetailRender traceId={hit.traceID || logTraceId} http={http} mode={mode}/>; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to enable event analytics traceID clicking/flyout pops out for jaeger indices