(query assist) show error toasts if summary is disabled #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
ps48,
kavithacm,
derek-ho,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
==========================================
+ Coverage 56.38% 56.39% +0.01%
==========================================
Files 322 322
Lines 11766 11769 +3
Branches 3059 3061 +2
==========================================
+ Hits 6634 6637 +3
Misses 5078 5078
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ps48
approved these changes
Mar 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7f363c7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
added a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Mar 5, 2024
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7f363c7)
joshuali925
pushed a commit
that referenced
this pull request
Mar 5, 2024
(cherry picked from commit 7f363c7) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…ensearch-project#1484) Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 8dab6a3ef00c7127f6713701187abac1addfc68a) Co-authored-by: Derek Ho <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…) (opensearch-project#1485) (cherry picked from commit 7f363c7) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit f1574be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we use summarization to explain PPL errors, but it won't be available if summarization feature is disabled. This PR enables sending error to toast message in that case.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.