[Backport 2.x] Add Index-based adaptor for integrations #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Update comment for json adaptor construction Signed-off-by: Simeon Widdis <[email protected]> * Stub index data adaptor class Signed-off-by: Simeon Widdis <[email protected]> * Add initial impl for findIntegrationVersions Signed-off-by: Simeon Widdis <[email protected]> * Fill in simple getDirectoryType implementation Signed-off-by: Simeon Widdis <[email protected]> * Implement index adaptor as wrapper for json adaptor Signed-off-by: Simeon Widdis <[email protected]> * Add integration template type for index Signed-off-by: Simeon Widdis <[email protected]> * Fix lints for server/routes Signed-off-by: Simeon Widdis <[email protected]> * Fix integrations_manager lints Signed-off-by: Simeon Widdis <[email protected]> * Refactor template manager to support multiple readers at once Signed-off-by: Simeon Widdis <[email protected]> * Rename FileSystemCatalogDataAdaptor -> FileSystemDataAdaptor Signed-off-by: Simeon Widdis <[email protected]> * Add IndexReader to existing Manager logic Signed-off-by: Simeon Widdis <[email protected]> * Fix plugin label type Signed-off-by: Simeon Widdis <[email protected]> * Add tests for index adaptor Signed-off-by: Simeon Widdis <[email protected]> * Add object management to integration objects Signed-off-by: Simeon Widdis <[email protected]> * Fix bug with version parsing for numeric integration names Signed-off-by: Simeon Widdis <[email protected]> * Prioritize dynamic integrations over defaults Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit ee3ca58) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1399 +/- ##
==========================================
+ Coverage 54.19% 54.29% +0.10%
==========================================
Files 314 315 +1
Lines 11114 11154 +40
Branches 2978 2982 +4
==========================================
+ Hits 6023 6056 +33
- Misses 5042 5049 +7
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swiddis
approved these changes
Feb 1, 2024
Swiddis
added
enhancement
joshuali925
approved these changes
Feb 1, 2024
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…pensearch-project#1396) (opensearch-project#1399) * Fixed get-started page image not adapting to the browser window size Signed-off-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> (cherry picked from commit ce57d868af80e95c3493f2da155ca16902a333f8)
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…roject#1399) * Update comment for json adaptor construction * Stub index data adaptor class * Add initial impl for findIntegrationVersions * Fill in simple getDirectoryType implementation * Implement index adaptor as wrapper for json adaptor * Add integration template type for index * Fix lints for server/routes * Fix integrations_manager lints * Refactor template manager to support multiple readers at once * Rename FileSystemCatalogDataAdaptor -> FileSystemDataAdaptor * Add IndexReader to existing Manager logic * Fix plugin label type * Add tests for index adaptor * Add object management to integration objects * Fix bug with version parsing for numeric integration names * Prioritize dynamic integrations over defaults --------- (cherry picked from commit ee3ca58) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 045306e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ee3ca58 from #1381.