-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize images in integrations repository #1387
Conversation
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis can u plz add a correspondent issue in the catalog repository for doing the same image reduction size there ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Simeon Widdis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
=======================================
Coverage 53.87% 53.87%
=======================================
Files 316 316
Lines 11309 11309
Branches 2957 2957
=======================================
Hits 6093 6093
Misses 5168 5168
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1387-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2ca2c751793c14bd951bf2d5294a75952ff5244e
# Push it to GitHub
git push --set-upstream origin backport/backport-1387-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
Need #1392 to backport |
* Optimize images in integrations repository Signed-off-by: Simeon Widdis <[email protected]> * Update test length threshold after optimization reduced it Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 2ca2c75) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Optimize images in integrations repository Signed-off-by: Simeon Widdis <[email protected]> * Update test length threshold after optimization reduced it Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
Description
Compression helps save space when encoding integrations to avoid the size limit for documents. Sample data is the other big asset type, I think a decent solution is to truncate it to e.g. 10 records, until the catalog is able to handle more large-file storage. Image size issues became relevant in #1381
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.