Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize images in integrations repository #1387

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Jan 29, 2024

Description

Compression helps save space when encoding integrations to avoid the size limit for documents. Sample data is the other big asset type, I think a decent solution is to truncate it to e.g. 10 records, until the catalog is able to handle more large-file storage. Image size issues became relevant in #1381

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@YANG-DB
Copy link
Member

YANG-DB commented Jan 29, 2024

@Swiddis can u plz add a correspondent issue in the catalog repository for doing the same image reduction size there ?

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5144529) 53.87% compared to head (8dbcf56) 53.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1387   +/-   ##
=======================================
  Coverage   53.87%   53.87%           
=======================================
  Files         316      316           
  Lines       11309    11309           
  Branches     2957     2957           
=======================================
  Hits         6093     6093           
  Misses       5168     5168           
  Partials       48       48           
Flag Coverage Δ
dashboards-observability 53.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swiddis Swiddis merged commit 2ca2c75 into opensearch-project:main Jan 29, 2024
14 of 20 checks passed
@Swiddis Swiddis deleted the compress-images branch January 29, 2024 22:13
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1387-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2ca2c751793c14bd951bf2d5294a75952ff5244e
# Push it to GitHub
git push --set-upstream origin backport/backport-1387-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1387-to-2.x.

@Swiddis
Copy link
Collaborator Author

Swiddis commented Jan 30, 2024

Need #1392 to backport

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2024
* Optimize images in integrations repository

Signed-off-by: Simeon Widdis <[email protected]>

* Update test length threshold after optimization reduced it

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit 2ca2c75)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit to paulstn/dashboards-observability that referenced this pull request Feb 1, 2024
* Optimize images in integrations repository

Signed-off-by: Simeon Widdis <[email protected]>

* Update test length threshold after optimization reduced it

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x integrations Used to denote items related to the Integrations project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants