Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] feat: enable data grid in Chatbot (#1341) #1383

Merged

Conversation

SuZhou-Joe
Copy link
Member

  • feat: enable data grid in Chatbot

Signed-off-by: SuZhou-Joe [email protected]

  • feat: update payload

Signed-off-by: SuZhou-Joe [email protected]

  • feat: add unit test

Signed-off-by: SuZhou-Joe [email protected]

  • feat: Optimize code

Co-authored-by: Joshua Li [email protected]
Signed-off-by: SuZhou-Joe [email protected]

  • feat: optimize code

Signed-off-by: SuZhou-Joe [email protected]

  • feat: change to MessageRenderer

Signed-off-by: SuZhou-Joe [email protected]

  • feat: change to fullWidth

Signed-off-by: SuZhou-Joe [email protected]


Signed-off-by: SuZhou-Joe [email protected]
Co-authored-by: Joshua Li [email protected]
Co-authored-by: Kavitha Conjeevaram Mohan [email protected]
(cherry picked from commit 745b4c2)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* feat: enable data grid in Chatbot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update payload

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: Optimize code

Co-authored-by: Joshua Li <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change to MessageRenderer

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change to fullWidth

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
(cherry picked from commit 745b4c2)
@joshuali925
Copy link
Member

not sure why some snapshots failed

Signed-off-by: SuZhou-Joe <[email protected]>
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d4d8dbc) 53.37% compared to head (d216bf3) 53.53%.

Files Patch % Lines
public/components/event_analytics/utils/utils.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1383      +/-   ##
==========================================
+ Coverage   53.37%   53.53%   +0.15%     
==========================================
  Files         310      312       +2     
  Lines       10920    10962      +42     
  Branches     2865     2879      +14     
==========================================
+ Hits         5829     5868      +39     
- Misses       5043     5046       +3     
  Partials       48       48              
Flag Coverage Δ
dashboards-observability 53.53% <97.14%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 merged commit b3430d1 into opensearch-project:2.x Jan 25, 2024
12 of 19 checks passed
@SuZhou-Joe
Copy link
Member Author

not sure why some snapshots failed

My fault that I did not update snapshot in previous PR and others help to update snapshot in seperate PR so this backport PR does not include the snapshot fix change, fixed that.

amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants