Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error from #1233 #1372

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Jan 18, 2024

Description

backport #1370

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925
Copy link
Member Author

joshuali925 commented Jan 18, 2024

duplicate of #1370

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67a5952) 52.90% compared to head (330fb26) 52.90%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #1372   +/-   ##
=======================================
  Coverage   52.90%   52.90%           
=======================================
  Files         302      302           
  Lines       10594    10594           
  Branches     2777     2777           
=======================================
  Hits         5605     5605           
  Misses       4944     4944           
  Partials       45       45           
Flag Coverage Δ
dashboards-observability 52.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 merged commit 57db4dc into opensearch-project:2.x Jan 18, 2024
23 of 40 checks passed
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants