Remove manual refresh for S3 integrations #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
YANG-DB
approved these changes
Nov 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #1226 +/- ##
==========================================
- Coverage 44.07% 44.06% -0.01%
==========================================
Files 329 329
Lines 19668 19672 +4
Branches 4735 4685 -50
==========================================
Hits 8669 8669
- Misses 10422 10958 +536
+ Partials 577 45 -532
Flags with carried forward coverage won't be shown. Click here to find out more. |
derek-ho
reviewed
Nov 2, 2023
| {table_name}; | ||
| {table_name} | ||
| WITH ( | ||
| auto_refresh = 'true', |
There was a problem hiding this comment.
any option to configure refresh?
There was a problem hiding this comment.
Not really, can maybe look at adding it in a future release
derek-ho
approved these changes
Nov 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit 80f112a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit 80f112a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of doing the refresh synchronously as part of integration installation, we configure the MV for autorefresh and let it run in the background. This can lead to some start-up time for integrations before showing data, but speeds up the installation process.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.