[Backport 2.11] [Explorer] Fixes for cancel button and saved object loading #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* remove unused files Signed-off-by: Eric Wei <[email protected]> * missing snapshots Signed-off-by: Eric Wei <[email protected]> * remove unused files Signed-off-by: Eric Wei <[email protected]> * move explorer button out of actions Signed-off-by: Eric <[email protected]> * fix cancel button isn't working issue Signed-off-by: Eric <[email protected]> * add sessionId to saved object loader Signed-off-by: Eric <[email protected]> * update snapshots Signed-off-by: Eric <[email protected]> * status update issue on object loading Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Eric <[email protected]> (cherry picked from commit e4e2bca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
mengweieric
approved these changes
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## 2.11 #1201 +/- ##
=======================================
Coverage 44.03% 44.03%
=======================================
Files 328 328
Lines 19634 19634
Branches 4730 4730
=======================================
Hits 8646 8646
Misses 10411 10411
Partials 577 577
Flags with carried forward coverage won't be shown. Click here to find out more. |
ps48
approved these changes
Oct 27, 2023
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Oct 30, 2023
* breakdown and related changes Signed-off-by: Eric Wei <[email protected]> * minor code removals Signed-off-by: Eric Wei <[email protected]> * data table fix Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Eric Wei <[email protected]>
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Nov 8, 2023
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Nov 8, 2023
…pensearch-project#1197) (opensearch-project#1201)" This reverts commit f0e7a9d. Signed-off-by: Eric <[email protected]>
mengweieric
added a commit
that referenced
this pull request
Nov 13, 2023
* Revert "Update empty allowed roles to admin only (#1217) (#1220)" This reverts commit 4288504. Signed-off-by: Eric <[email protected]> * Revert "Increment version to 2.11.1.0 (#1190)" This reverts commit ccd5fb8. Signed-off-by: Eric <[email protected]> * Revert "Add S3 integration for Nginx and VPC (#1214) (#1216)" This reverts commit e0a509c. Signed-off-by: Eric <[email protected]> * Revert "disabling inspect and default pattern/timestamp buttons when using async data sources (#1205) (#1212)" This reverts commit ca5ad02. Signed-off-by: Eric <[email protected]> * Revert "Saved object datasource backward compatibility fixes (#1208) (#1210)" This reverts commit 467a0b3. Signed-off-by: Eric <[email protected]> * Revert "Link integrations from datasources UI (#1203) (#1207)" This reverts commit 8e9fe5e. Signed-off-by: Eric <[email protected]> * Revert "[Explorer] Fixes for cancel button and saved object loading (#1197) (#1201)" This reverts commit f0e7a9d. Signed-off-by: Eric <[email protected]> * Revert "Correct query schema for ELB mview generation (#1196) (#1199)" This reverts commit 0b7be95. Signed-off-by: Eric <[email protected]> * Revert "[Backport 2.11] Add integrations queries for Flint (#1195)" This reverts commit 97f46ba. Signed-off-by: Eric <[email protected]> * Revert "remove husky pre-commit checks (#1192) (#1193)" This reverts commit 25d52f3. Signed-off-by: Eric <[email protected]> * Revert "Bug fixes for observability count distribution and application analytics (#1187) (#1189)" This reverts commit e2440d2. Signed-off-by: Eric <[email protected]> * Revert "Support cancellation of async queries (#1177) (#1186)" This reverts commit 6b495f3. Signed-off-by: Eric <[email protected]> * Revert "[Explorer] Supports session for s3 direct query (#1178) (#1183)" This reverts commit d50047f. Signed-off-by: Eric <[email protected]> * Revert "[Explorer] Modify text in empty prompt (#1172) (#1182)" This reverts commit 95a60cc. Signed-off-by: Eric <[email protected]> * Revert "[Feature] Match discover look and feel (#1135) (#1179)" This reverts commit b69801e. Signed-off-by: Eric <[email protected]> * Revert "config panel dark mode fix (#1169) (#1176)" This reverts commit 34696b3. Signed-off-by: Eric <[email protected]> * Revert "Fix events home table and toast life time (#1170)" This reverts commit a9b36fc. Signed-off-by: Eric <[email protected]> * Revert "Quiet react-dnd draggableId/droppableId warnings. (#1147) (#1166)" This reverts commit a2f9a00. Signed-off-by: Eric <[email protected]> * Revert "Fix integration labeling to identify S3 integrations (#1157) (#1164)" This reverts commit 9de9aea. Signed-off-by: Eric <[email protected]> * Revert "Remove loading progress for integration setup (#1156) (#1162)" This reverts commit a08721b. Signed-off-by: Eric <[email protected]> * Revert "Switch from toast to callout for integration set up failures (#1155) (#1159)" This reverts commit e6a474a. Signed-off-by: Eric <[email protected]> * Revert "Disable integration set up button if invalid (#1152) (#1161)" This reverts commit 74aae17. Signed-off-by: Eric <[email protected]> * Revert "Update URL of create datasources, fix spacing (#1149) (#1154)" This reverts commit 0b66d83. Signed-off-by: Eric <[email protected]> * Revert "Allow patch on allowedRoles (#1143) (#1145)" This reverts commit 0acc0f3. Signed-off-by: Eric <[email protected]> * Revert "fix for explorer data grid not paginating (#1139) (#1141)" This reverts commit c5ead50. Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]>
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…arch-project#1201) (opensearch-project#1214) (cherry picked from commit 257325caaeb4810cdac8473f9a98120bda072bfa) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e4e2bca from #1197.