[Backport 2.x] [Explorer] Fixes for cancel button and saved object loading #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* remove unused files Signed-off-by: Eric Wei <[email protected]> * missing snapshots Signed-off-by: Eric Wei <[email protected]> * remove unused files Signed-off-by: Eric Wei <[email protected]> * move explorer button out of actions Signed-off-by: Eric <[email protected]> * fix cancel button isn't working issue Signed-off-by: Eric <[email protected]> * add sessionId to saved object loader Signed-off-by: Eric <[email protected]> * update snapshots Signed-off-by: Eric <[email protected]> * status update issue on object loading Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Eric <[email protected]> (cherry picked from commit e4e2bca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
mengweieric
approved these changes
Oct 27, 2023
ps48
approved these changes
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1200 +/- ##
=======================================
Coverage 44.03% 44.03%
=======================================
Files 328 328
Lines 19634 19634
Branches 4730 4730
=======================================
Hits 8646 8646
Misses 10411 10411
Partials 577 577
Flags with carried forward coverage won't be shown. Click here to find out more. |
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ch-project#1197) (opensearch-project#1200) * remove unused files * missing snapshots * remove unused files * move explorer button out of actions * fix cancel button isn't working issue * add sessionId to saved object loader * update snapshots * status update issue on object loading --------- (cherry picked from commit e4e2bca) Signed-off-by: Eric Wei <[email protected]> Signed-off-by: Eric <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit a1234af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e4e2bca from #1197.