-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integrations queries for Flint #1150
Conversation
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
- Coverage 44.01% 44.01% -0.01%
==========================================
Files 328 328
Lines 19612 19644 +32
Branches 4733 4730 -3
==========================================
+ Hits 8632 8646 +14
- Misses 10406 10421 +15
- Partials 574 577 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swiddis
thanks for all the work
can u also update the appropriate assets in the corresponding catalog integration PR ?
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
title: 'Table', | ||
lower: 'table', | ||
help: 'Select a table to pull the data from.', | ||
title: 'Catalog', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why catalog here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the form isn't referring to a table, I asked around for a better name.
@@ -185,6 +188,7 @@ export function SetupIntegrationForm({ | |||
[] as Array<{ label: string }> | |||
); | |||
const [isSuggestionsLoading, setIsSuggestionsLoading] = useState(true); | |||
const [isBlurred, setIsBlurred] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is also onBlur function that comes along with most elements that you can use and avoid this separate re-implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is it documented? I'd heard about it but didn't find any references.
Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit 22b6fc6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 22b6fc6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
For making integrations work with Flint, we need to provide a set of queries that can be used to create OpenSearch indices for querying. The PR is still in the draft phase as we compile our queries and work towards testing them in real scenarios, and adding unit tests + documentation for the functionality.
Todo:
Nginx Table QueriesGet VPC Flow queries from @YANG-DBGet Cloudtrail queries from @YANG-DB (available in update the cloudtrail s3 integration assets opensearch-catalog#81)Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.