Remove create and delete options for datasources #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1146 +/- ##
==========================================
+ Coverage 44.21% 44.25% +0.03%
==========================================
Files 329 329
Lines 19542 19525 -17
Branches 4719 4718 -1
==========================================
- Hits 8641 8640 -1
+ Misses 10334 10318 -16
Partials 567 567
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Spoke with @derek-ho no need to keep this PR. |
RyanL1997
added a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…1186) * Saved Object Aggregation View (opensearch-project#1146) * Move tenant-related utils to common folder (opensearch-project#1184) * [Saved Object Aggregation View] Use namespace registry to add tenant filter (opensearch-project#1169) Signed-off-by: Chang Liu <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Yan Zeng <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Co-authored-by: Craig Perkins <[email protected]> Co-authored-by: Yan Zeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.