[Backport 2.x] Allow patch on allowedRoles #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Allow patch on allowedRoles Signed-off-by: Derek Ho <[email protected]> * Change for patch Signed-off-by: Derek Ho <[email protected]> * Address PR comments Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit cccfebf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
derek-ho
approved these changes
Oct 20, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1144 +/- ##
==========================================
+ Coverage 44.22% 44.24% +0.01%
==========================================
Files 327 329 +2
Lines 19477 19532 +55
Branches 4706 4719 +13
==========================================
+ Hits 8614 8641 +27
- Misses 10297 10324 +27
- Partials 566 567 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Swiddis
approved these changes
Oct 23, 2023
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ject#1144) * Allow patch on allowedRoles * Change for patch * Address PR comments --------- (cherry picked from commit cccfebf) Signed-off-by: Derek Ho <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit d5e7636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport cccfebf from #1143.