Move Metrics Explorer date span, range into redux metrics-slice #1105
+96
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Fitzgibbons <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
+ Coverage 44.09% 44.37% +0.27%
==========================================
Files 325 327 +2
Lines 19378 19896 +518
Branches 4617 4743 +126
==========================================
+ Hits 8545 8829 +284
- Misses 10788 11021 +233
- Partials 45 46 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
pjfitzgibbons
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
joshuali925
approved these changes
Oct 10, 2023
YANG-DB
approved these changes
Oct 10, 2023
derek-ho
reviewed
Oct 10, 2023
| start: 'now-1d', | ||
| end: 'now', | ||
| span: 1, | ||
| resolution: 'h', |
There was a problem hiding this comment.
Was this set anywhere before as the default?
derek-ho
reviewed
Oct 10, 2023
Comment on lines
+736
to
+739
| fromTime="now-1d" | ||
| key="Y4muP4QBiaYaSxpXk7r8" | ||
| onEditClick={[MockFunction]} | ||
| onRefresh={true} | ||
| onRefresh={0} |
There was a problem hiding this comment.
is this expected - default from 30m to 1d? Also why is onRefresh turning into false here, is that expected?
mengweieric
pushed a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Oct 15, 2023
…search-project#1105) Signed-off-by: Peter Fitzgibbons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to simplify refactor of MetricsGrid, moving all date-range parsing out of props-passing and into redux MetricsSlice.
Issues Resolved
References #1095 (not resolve)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.