Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer minor UI updates #1096

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Explorer minor UI updates #1096

merged 4 commits into from
Oct 6, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Oct 6, 2023 •
edited
Loading

Description

Explorer minor UI updates for look and feel changes

Issues Resolved

  1. Style changes to data source picker
  2. Style changes to language picker
  3. Added default languages
  4. Hide patterns and timechart on s3 datasource
  5. Remove panel for side cards
  6. Update workbench navigation link
  7. Reset query when datasource is not index patterns
  8. Updated test snapshots

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48
explorer ui updates
fb1dbf6 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 marked this pull request as draft October 6, 2023 20:05
ps48 added 2 commits October 6, 2023 13:22
@ps48
bug fixes and snapshot update
90a77d3 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48
update app analytics tests
0135bdd 
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 marked this pull request as ready for review October 6, 2023 20:56
@ps48
update view test snapshots
6a46d29 
Signed-off-by: Shenoy Pratik <[email protected]>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1096 (6a46d29) into main (849b953) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   44.11%   44.09%   -0.03%     
==========================================
  Files         325      325              
  Lines       19368    19378      +10     
  Branches     4617     4617              
==========================================
  Hits         8545     8545              
- Misses      10778    10788      +10     
  Partials       45       45
Flag Coverage Δ
dashboards-observability 44.09% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@ps48 ps48 merged commit 34068f1 into opensearch-project:main Oct 6, 2023
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
@github-actions
Explorer minor UI updates (#1096)
611be94 
* explorer ui updates

Signed-off-by: Shenoy Pratik <[email protected]>

* bug fixes and snapshot update

Signed-off-by: Shenoy Pratik <[email protected]>

* update app analytics tests

Signed-off-by: Shenoy Pratik <[email protected]>

* update view test snapshots

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 34068f1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
@github-actions
Explorer minor UI updates (#1096)
e69815f 
* explorer ui updates

Signed-off-by: Shenoy Pratik <[email protected]>

* bug fixes and snapshot update

Signed-off-by: Shenoy Pratik <[email protected]>

* update app analytics tests

Signed-off-by: Shenoy Pratik <[email protected]>

* update view test snapshots

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 34068f1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 6, 2023
Merged
ps48 pushed a commit that referenced this pull request Oct 6, 2023
@opensearch-trigger-bot @github-actions
Explorer minor UI updates (#1096) (#1100)
e4cec76 
* explorer ui updates



* bug fixes and snapshot update



* update app analytics tests



* update view test snapshots



---------


(cherry picked from commit 34068f1)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 6, 2023
@opensearch-trigger-bot @github-actions
Explorer minor UI updates (#1096) (#1099)
c9d5367 
* explorer ui updates



* bug fixes and snapshot update



* update app analytics tests



* update view test snapshots



---------


(cherry picked from commit 34068f1)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit to mengweieric/dashboards-observability that referenced this pull request Oct 15, 2023
@ps48 @mengweieric
Explorer minor UI updates (opensearch-project#1096)
18566df 
* explorer ui updates

Signed-off-by: Shenoy Pratik <[email protected]>

* bug fixes and snapshot update

Signed-off-by: Shenoy Pratik <[email protected]>

* update app analytics tests

Signed-off-by: Shenoy Pratik <[email protected]>

* update view test snapshots

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot
Explorer minor UI updates (opensearch-project#1096) (opensearch-proje…
9ed168d 
…ct#1099)

* explorer ui updates

* bug fixes and snapshot update

* update app analytics tests

* update view test snapshots

---------

(cherry picked from commit 34068f1)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c9d5367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmmusings vmmusings vmmusings approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

@kavithacm kavithacm kavithacm approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@derek-ho derek-ho Awaiting requested review from derek-ho

@dai-chen dai-chen Awaiting requested review from dai-chen

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric

@Swiddis Swiddis Awaiting requested review from Swiddis

@penghuo penghuo Awaiting requested review from penghuo

@seankao-az seankao-az Awaiting requested review from seankao-az

@anirudha anirudha Awaiting requested review from anirudha

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ps48 @kavithacm @joshuali925 @vmmusings