Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
Signed-off-by: Joshua Li <[email protected]>
  • Loading branch information
joshuali925 committed Jan 22, 2024
1 parent 9adabcf commit cc674bc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ export function DataGrid(props: DataGridProps) {
http,
pplService,
rows,
rowsAll,
explorerFields,
timeStampField,
rawQuery,
Expand Down Expand Up @@ -108,7 +107,7 @@ export function DataGrid(props: DataGridProps) {
// creates the header for each column listing what that column is
const dataGridColumns = () => {
const columns: EuiDataGridColumn[] = [];
selectedColumns.map(({ name, type }) => {
selectedColumns.map(({ name }) => {
if (name === 'timestamp') {
columns.push(DEFAULT_TIMESTAMP_COLUMN);
} else if (name === '_source') {
Expand All @@ -133,7 +132,7 @@ export function DataGrid(props: DataGridProps) {
});
return {
visibleColumns: columns,
setVisibleColumns: (visibleColumns: string[]) => {
setVisibleColumns: () => {

Check warning on line 135 in public/components/event_analytics/explorer/events_views/data_grid.tsx

View check run for this annotation

Codecov / codecov/patch

public/components/event_analytics/explorer/events_views/data_grid.tsx#L135

Added line #L135 was not covered by tests
// TODO: implement with sidebar field order (dragability) changes
},
};
Expand Down
3 changes: 1 addition & 2 deletions public/components/metrics/redux/slices/metrics_slice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -265,15 +265,14 @@ export const addSelectedMetric = (metric: MetricType) => async (dispatch, getSta
await dispatch(selectMetric(metric));
};

export const removeSelectedMetric = ({ id }) => async (dispatch, getState) => {
export const removeSelectedMetric = ({ id }) => async (dispatch, _getState) => {
dispatch(deSelectMetric(id));
};

export const updateMetricQuery = (id, { availableAttributes, aggregation, attributesGroupBy }) => (
dispatch,
getState
) => {
const state = getState();
const staticMetric = getState().metrics.metrics[id];
const metric = {
...staticMetric,
Expand Down
1 change: 0 additions & 1 deletion public/framework/core_refs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import {
ApplicationStart,
ChromeStart,
CoreStart,
HttpStart,
IToasts,
SavedObjectsClientContract,
Expand Down
8 changes: 1 addition & 7 deletions server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,7 @@ export class ObservabilityPlugin
this.logger = initializerContext.logger.get();
}

public async setup(
core: CoreSetup,
deps: {
assistantDashboards?: AssistantPluginSetup;
}
) {
const { assistantDashboards } = deps;
public async setup(core: CoreSetup) {
this.logger.debug('Observability: Setup');
const router = core.http.createRouter();
const config = await this.initializerContext.config
Expand Down

0 comments on commit cc674bc

Please sign in to comment.