Fix dropdown display behavior (#1114)

(cherry picked from commit 68d88f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Oct 11, 2023 · 5544c28 · 5544c28
1 parent 9c014db
commit 5544c28
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 55 deletions.
diff --git a/...omponents/integrations/components/__tests__/__snapshots__/setup_integration.test.tsx.snap b/...omponents/integrations/components/__tests__/__snapshots__/setup_integration.test.tsx.snap
@@ -200,20 +200,7 @@ exports[`Integration Setup Page Renders integration setup page as expected 1`] =
                                   onBlur={[Function]}
                                   onChange={[Function]}
                                   onFocus={[Function]}
-                                  options={
-                                    Array [
-                                      Object {
-                                        "disabled": true,
-                                        "text": "S3 Connection",
-                                        "value": "s3",
-                                      },
-                                      Object {
-                                        "disabled": true,
-                                        "text": "OpenSearch Index",
-                                        "value": "index",
-                                      },
-                                    ]
-                                  }
+                                  options={Array []}
                                   value="index"
                                 >
                                   <EuiFormControlLayout
@@ -244,22 +231,7 @@ exports[`Integration Setup Page Renders integration setup page as expected 1`] =
                                             onFocus={[Function]}
                                             onMouseUp={[Function]}
                                             value="index"
-                                          >
-                                            <option
-                                              disabled={true}
-                                              key="0"
-                                              value="s3"
-                                            >
-                                              S3 Connection
-                                            </option>
-                                            <option
-                                              disabled={true}
-                                              key="1"
-                                              value="index"
-                                            >
-                                              OpenSearch Index
-                                            </option>
-                                          </select>
+                                          />
                                         </EuiValidatableControl>
                                         <EuiFormControlLayoutIcons
                                           compressed={false}
@@ -1212,12 +1184,6 @@ exports[`Integration Setup Page Renders the form as expected 1`] = `
               options={
                 Array [
                   Object {
-                    "disabled": true,
-                    "text": "S3 Connection",
-                    "value": "s3",
-                  },
-                  Object {
-                    "disabled": false,
                     "text": "OpenSearch Index",
                     "value": "index",
                   },
@@ -1255,15 +1221,7 @@ exports[`Integration Setup Page Renders the form as expected 1`] = `
                         value="index"
                       >
                         <option
-                          disabled={true}
                           key="0"
-                          value="s3"
-                        >
-                          S3 Connection
-                        </option>
-                        <option
-                          disabled={false}
-                          key="1"
                           value="index"
                         >
                           OpenSearch Index

diff --git a/public/components/integrations/components/setup_integration.tsx b/public/components/integrations/components/setup_integration.tsx
@@ -212,17 +212,13 @@ export function SetupIntegrationForm({
       <EuiSpacer />
       <EuiFormRow label="Data Source" helpText="Select a data source to connect to.">
         <EuiSelect
-          options={integrationConnectionSelectorItems.map((item) => {
-            const copy: { value: string; text: string; disabled?: boolean } = { ...item };
-            switch (item.value) {
-              case 's3':
-                copy.disabled = !Object.hasOwn(integration.assets ?? {}, 'queries');
-                return copy;
-              case 'index':
-                copy.disabled = !Object.hasOwn(integration.assets ?? {}, 'savedObjects');
-                return copy;
-              default:
-                return copy;
+          options={integrationConnectionSelectorItems.filter((item) => {
+            if (item.value === 's3') {
+              return Object.hasOwn(integration.assets ?? {}, 'queries');
+            } else if (item.value === 'index') {
+              return Object.hasOwn(integration.assets ?? {}, 'savedObjects');
+            } else {
+              return false;
             }
           })}
           value={config.connectionType}