Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node.js and Yarn installation in CI #16

Closed

Conversation

AMoo-Miki
Copy link
Contributor

Description

The GitHub workflow uses the engines from OSD incorrectly. This change fixes that.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AMoo-Miki AMoo-Miki requested a review from a team February 22, 2023 07:03
@AWSHurneyt
Copy link
Collaborator

Here's a portion of the error logs.

e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:

    class org.opensearch.commons.notifications.action.BaseResponse, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
> Task :notifications:compileKotlin FAILED
    class org.opensearch.commons.notifications.action.DeleteNotificationConfigRequest, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
    class org.opensearch.commons.notifications.action.CreateNotificationConfigRequest, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
    class org.opensearch.commons.notifications.action.GetChannelListRequest, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
    class org.opensearch.commons.notifications.action.GetNotificationConfigRequest, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
    class org.opensearch.commons.notifications.action.GetPluginFeaturesRequest, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
    class org.opensearch.commons.notifications.action.SendNotificationRequest, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
    class org.opensearch.commons.notifications.action.UpdateNotificationConfigRequest, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
    class org.opensearch.commons.notifications.model.BaseModel, unresolved supertypes: org.opensearch.common.xcontent.ToXContentObject
    class org.opensearch.commons.authuser.User, unresolved supertypes: org.opensearch.common.xcontent.ToXContent
Adding -Xextended-compiler-checks argument might provide additional information.

Looks like some of these imports may be related to this change in OS core opensearch-project/OpenSearch#5902.

ISM started correcting their imports in this PR opensearch-project/index-management#696

@dblock
Copy link
Member

dblock commented Jul 15, 2024

@AMoo-Miki is this still needed? Close?

[Catch All Triage - 1, 2, 3, 4]

@AMoo-Miki
Copy link
Contributor Author

Not anymore. This PR was reinvented in a series of other PRs.

@AMoo-Miki AMoo-Miki closed this Aug 17, 2024
@AMoo-Miki AMoo-Miki deleted the gh-ci-fix-node-yarn branch October 16, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants