Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Rename opendistro in strings, APIs and settings #26

Merged
merged 12 commits into from
May 24, 2021
Merged

Rename opendistro in strings, APIs and settings #26

merged 12 commits into from
May 24, 2021

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented May 19, 2021

Signed-off-by: Joshua Li [email protected]

Description

Rename opendistro/odfe in docs and strings, packages, API, settings.
Backward compatibility not needed because notebooks backend only exists in opensearch.

Note:
"opendistro" in security index (.opendistro_security) and cluster permissions (cluster:admin/opendistro/notebooks/...) are not changed because of security plugin dependency

Issues Resolved

#22

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 self-assigned this May 19, 2021
@joshuali925 joshuali925 marked this pull request as draft May 19, 2021 22:44
@davidcui1225
Copy link
Contributor

How come the directory path in opensearch-notebooks is not changed from com/amazon/opendistroforelasticsearch to org/opensearch if all the files have the namespace change?

@joshuali925
Copy link
Member Author

How come the directory path in opensearch-notebooks is not changed from com/amazon/opendistroforelasticsearch to org/opensearch if all the files have the namespace change?

Thanks, I missed that.. I wasn't able to build it because of common utils dependency, will change and verify

@joshuali925 joshuali925 marked this pull request as ready for review May 21, 2021 19:29
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshuali925 joshuali925 merged commit 566e198 into opensearch-project:dev May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants