This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Rename opendistro in strings, APIs and settings #26
Merged
joshuali925
merged 12 commits into
opensearch-project:dev
from
joshuali925:odfe-compatibility
May 24, 2021
Merged
Rename opendistro in strings, APIs and settings #26
joshuali925
merged 12 commits into
opensearch-project:dev
from
joshuali925:odfe-compatibility
May 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
How come the directory path in opensearch-notebooks is not changed from |
Thanks, I missed that.. I wasn't able to build it because of common utils dependency, will change and verify |
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
davidcui1225
approved these changes
May 21, 2021
zhongnansu
approved these changes
May 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Joshua Li <[email protected]>
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li [email protected]
Description
Rename opendistro/odfe in docs and strings, packages, API, settings.
Backward compatibility not needed because notebooks backend only exists in opensearch.
Note:
"opendistro" in security index (
.opendistro_security
) and cluster permissions (cluster:admin/opendistro/notebooks/...
) are not changed because of security plugin dependencyIssues Resolved
#22
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.