Integrate layerList to store and add breadcrumbs #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <[email protected]>
|
Shall we update breadcrumb immediately with name once it is saved for first time? |
Makes sense to immediately update breadcrumb once saved. Updated the code, you could check the updated demo as well. |
Signed-off-by: Junqiu Lei <[email protected]>
VijayanB
reviewed
Nov 2, 2022
VijayanB
reviewed
Nov 2, 2022
maps_dashboards/public/components/layer_control_panel/layer_control_panel.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Junqiu Lei <[email protected]>
ashwin-pc
reviewed
Nov 3, 2022
maps_dashboards/public/components/layer_control_panel/layer_control_panel.tsx
Outdated
Show resolved
Hide resolved
|
@ashwin-pc Thanks your helpful feedback here and offline discussion! I updated the PR to make fetch saved object at top level component, and for the layers hook, I found most of components need use it and it doesn't have too much levels of component, I prefer to remain the existing hooks to use. |
Signed-off-by: Junqiu Lei <[email protected]>
VijayanB
previously approved these changes
Nov 8, 2022
ashwin-pc
reviewed
Nov 9, 2022
maps_dashboards/public/components/layer_control_panel/layer_control_panel.tsx
Show resolved
Hide resolved
Signed-off-by: Junqiu Lei <[email protected]>
VijayanB
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei [email protected]
Description
app/maps-dashboards/{id}Issues Resolved
#68
Demo
map_demo_integrate_layers_to_store.mov
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.