Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new layer functions for opensearch map layer #66

Merged
merged 2 commits into from
Oct 21, 2022
Merged

add new layer functions for opensearch map layer #66

merged 2 commits into from
Oct 21, 2022

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Oct 20, 2022 •
edited
Loading

Signed-off-by: Junqiu Lei [email protected]

Description

  • Allow to add and delete layers of OpenSearch maps layer.
  • Move all layers function logic to Model folder.
  • Add current zoom level display at right bottom on maps page.

Issue

#61

Demo

OSM_layer_functions.mov

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@junqiu-lei junqiu-lei changed the title add layers functions to common place and add zoom bar add new layer functions for opensearch map layer Oct 21, 2022
@junqiu-lei junqiu-lei self-assigned this Oct 21, 2022
@junqiu-lei junqiu-lei marked this pull request as ready for review October 21, 2022 21:34
@junqiu-lei junqiu-lei requested a review from a team October 21, 2022 21:34
heemin32
heemin32 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@heemin32 heemin32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junqiu-lei junqiu-lei merged commit c71a068 into opensearch-project:feature/new-maps Oct 21, 2022
@junqiu-lei junqiu-lei deleted the move-functions-common branch February 23, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VijayanB VijayanB VijayanB approved these changes

@heemin32 heemin32 heemin32 approved these changes

Assignees

@junqiu-lei junqiu-lei

Labels
feature maps-dashboards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junqiu-lei @heemin32 @VijayanB