Refresh custom wms layer+source on update (issue 601) #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2024 08:16
Signed-off-by: Quinn Guerin <[email protected]>
Signed-off-by: Quinn Guerin <[email protected]>
qugu2427
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
added 2 commits
July 9, 2024 15:15
Signed-off-by: Quinn Guerin <[email protected]>
Signed-off-by: Quinn Guerin <[email protected]>
qugu2427
changed the title
|
Thank you @qugu2427 for raising the PR, could you please add some test screenshot/video in this PR? |
|
@junqiu-lei sure, here is a video of the issue currently and with the refresh method |
|
The cypress failure of documentsLayer is due to CI runner capacity. |
naveentatikonda
approved these changes
Jul 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Quinn Guerin <[email protected]> (cherry picked from commit 605e894)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Quinn Guerin <[email protected]> (cherry picked from commit 605e894)
junqiu-lei
pushed a commit
that referenced
this pull request
Jul 17, 2024
Signed-off-by: Quinn Guerin <[email protected]> (cherry picked from commit 605e894) Co-authored-by: Quinn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UpdateLayerConfig()is broken as per #601. Specifically, line 36maplibreInstance.style.sourceCaches[layerConfig.id].update(maplibreInstance.transform)throws a object reference error. I suspectmaplibreInstance.transformis gone by the time it's used. Additionally, there are alot of what seem to be workarounds in the function, namely calling seemingly private methods of MaplibreGL and a spelling mistake. While I am by no means familiar with this codebase, it seems that simply deleting and refreshing the layer+source would be a better option. Especially, since updating wms fields would require a full refresh of tiles anyway.Issues Resolved
#601
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.