Add data source reference id in data layer search request #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
junqiu-lei
force-pushed
the
search-add-ref-id
branch
from
b7ab48f to
82e18e1
Compare
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
search-add-ref-id
branch
from
82e18e1 to
2bbe27d
Compare
BionIT
approved these changes
Jun 10, 2024
ZilongX
approved these changes
Jun 10, 2024
naveentatikonda
approved these changes
Jun 10, 2024
|
E2E Cypress tests CI would fail which is due to CI issue itself. |
|
Thanks @junqiu-lei for the quick fix ! |
VijayanB
approved these changes
Jun 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit 1e88c71)
junqiu-lei
added a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit 1e88c71) Co-authored-by: Junqiu Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add data source reference id in data layer search request to avoid potential search error if there is no local cluster.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.