add base map layer functions #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
previously approved these changes
Oct 14, 2022
VijayanB
reviewed
Oct 17, 2022
VijayanB
reviewed
Oct 17, 2022
VijayanB
reviewed
Oct 17, 2022
src/plugins/maps_dashboards/public/components/layer_control_panel/layer_control_panel.tsx
Outdated
Show resolved
Hide resolved
|
Will current zoom level be displayed at bottom right? |
Yes, will create a PR to add this display feature. |
Signed-off-by: Junqiu Lei <[email protected]>
VijayanB
approved these changes
Oct 17, 2022
heemin32
approved these changes
Oct 17, 2022
martin-gaievski
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei [email protected]
Description
This PR adding functions for base map layer: set up zoom zoom range, opacity, name, hide/show and delete.
Screen recording demo
base_map_layer_functions_demo.mov
Issues Resolved
#61
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.