Add config layer basic component #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <[email protected]>
VijayanB
reviewed
Oct 3, 2022
| { | ||
| label: 'Base Map', | ||
| iconType: 'visMapRegion', | ||
| id: 'example_id_1', | ||
| type: LAYER_TYPE.BASE_MAP, | ||
| name: 'Base Map Layer', |
There was a problem hiding this comment.
Yes, that's a example, will update when integrated with layer models
VijayanB
approved these changes
Oct 3, 2022
| @@ -0,0 +1,9 @@ | |||
|
|
|||
| //TODO: this is used for UI component development, remove or update it once layer model ready | |||
There was a problem hiding this comment.
do we have a github issue or sprint task to address this todo item?
There was a problem hiding this comment.
Yes, just created a gihub issue to track this. #56 Thanks!
martin-gaievski
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.