Add layer panel component #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivamdhar
reviewed
Sep 15, 2022
There was a problem hiding this comment.
Please make use of aria-label for all the UI elements added (for all semantic HTML tags). https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label
src/plugins/maps_dashboards/public/components/layer_control_panel/layer_control_panel.tsx
Outdated
Show resolved
Hide resolved
src/plugins/maps_dashboards/public/components/layer_control_panel/layer_control_panel.scss
Outdated
Show resolved
Hide resolved
ashwin-pc
reviewed
Sep 19, 2022
src/plugins/maps_dashboards/public/components/add_layer_panel/add_layer_panel.scss
Outdated
Show resolved
Hide resolved
src/plugins/maps_dashboards/public/components/layer_control_panel/layer_control_panel.scss
Outdated
Show resolved
Hide resolved
src/plugins/maps_dashboards/public/components/layer_control_panel/layer_control_panel.scss
Outdated
Show resolved
Hide resolved
src/plugins/maps_dashboards/public/components/layer_control_panel/layer_control_panel.tsx
Outdated
Show resolved
Hide resolved
ashwin-pc
reviewed
Sep 19, 2022
Signed-off-by: Junqiu Lei <[email protected]>
Shivamdhar
approved these changes
Sep 23, 2022
ashwin-pc
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei [email protected]
Description
Added UI: add layer button, hide layer button and delete layer button.
Added function: When click on "Add layer" button at layer control panel, it will go to Add layer panel modal.
Screenshot
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.