add map page and add basic layers panel #40
Conversation
|
The alignment of the Layers and Roadmap in the screenshot seems to be not correct. Please fix that. |
|
Also can we add the UX designer on this PR so that he can take a look at the screen shot only. So that there are no obvious alignment and other issues. |
The commits I pushed is for the basic functions, will follow up UX design and update the PR. |
Sure, since it's new plugin, currently there seems no check workflow related to this feature branch, will add some. |
Yes, we need verify on the UI. Currently this PR are more focus on the basic functions, will ask UX designer for review once we have the final UI component as designed. |
| export const MAP_VECTOR_TILE_URL = | ||
| 'https://dldbnqfps17cd.cloudfront.net/styles/basic-preview/compressedstyle.json'; |
There was a problem hiding this comment.
why we cannot replace it right now? If there is a tracking GH issue please attach a TODO here
There was a problem hiding this comment.
Since the production vector tiles service uses OpenStreetMap, which is under review by legal team, will update then.
| export const MAP_INITIAL_STATE = { | ||
| lng: 11, | ||
| lat: 49, | ||
| zoom: 2, | ||
| }; |
There was a problem hiding this comment.
please specify what these coordinates represents.
There was a problem hiding this comment.
Will update to
lng: 0,
lat: 0,
zoom: 1,
| </> | ||
| <div> | ||
| <Switch> | ||
| <Route exact path="/create-map" render={(props) => <Map />} /> |
There was a problem hiding this comment.
should we make constants for these path names?
| */ | ||
|
|
||
| @import "maplibre-gl/dist/maplibre-gl.css"; | ||
|
|
||
| /* stylelint-disable no-empty-source */ |
There was a problem hiding this comment.
We need remain it for Maplibre right format https://maplibre.org/maplibre-gl-js-docs/api/#maplibre-css.
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei [email protected]
Description
Issue
#44
Screenshot
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.