Add support to draw rectangle shape to filter documents #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
changed the title
VijayanB
force-pushed
the
add-rectangle-ui
branch
from
e1823aa to
162096f
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 85.71% 84.04% -1.68%
==========================================
Files 18 19 +1
Lines 448 470 +22
Branches 66 71 +5
==========================================
+ Hits 384 395 +11
- Misses 43 53 +10
- Partials 21 22 +1 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
VijayanB
force-pushed
the
add-rectangle-ui
branch
from
162096f to
f929262
Compare
Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
add-rectangle-ui
branch
from
f929262 to
e704224
Compare
junqiu-lei
reviewed
Mar 15, 2023
| @@ -53,6 +62,8 @@ export const DrawFilterShape = ({ | |||
| useEffect(() => { | |||
| if (filterProperties.mode === FILTER_DRAW_MODE.POLYGON) { | |||
| mapboxDrawRef.current.changeMode(MAPBOX_GL_DRAW_MODES.DRAW_POLYGON); | |||
| } else if (filterProperties.mode === FILTER_DRAW_MODE.RECTANGLE) { | |||
| mapboxDrawRef.current.changeMode(MAPBOX_GL_DRAW_MODES.DRAW_RECTANGLE); | |||
| } else { | |||
| // default mode | |||
| mapboxDrawRef.current.changeMode(MAPBOX_GL_DRAW_MODES.SIMPLE_SELECT); | |||
There was a problem hiding this comment.
How about use switch here?
function setDrawMode(mode) {
switch (mode) {
case FILTER_DRAW_MODE.POLYGON:
return MAPBOX_GL_DRAW_MODES.DRAW_POLYGON;
case FILTER_DRAW_MODE.RECTANGLE:
return MAPBOX_GL_DRAW_MODES.DRAW_RECTANGLE;
default:
return MAPBOX_GL_DRAW_MODES.SIMPLE_SELECT;
}
}
useEffect(() => {
mapboxDrawRef.current.changeMode(setDrawMode(filterProperties.mode));
}, [filterProperties.mode]);
|
From the demo video, there are two draw controller icons, is it expected? |
I am waiting for new 'rectangle icon " from UX. Will replace it in new PR. |
Signed-off-by: Vijayan Balasubramanian <[email protected]>
junqiu-lei
previously approved these changes
Mar 16, 2023
martin-gaievski
previously approved these changes
Mar 21, 2023
VijayanB
dismissed stale reviews from martin-gaievski and junqiu-lei
via
f5b5c2b
junqiu-lei
approved these changes
Mar 22, 2023
martin-gaievski
approved these changes
Mar 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Add rectangle ui tool bar Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit a42c915)
VijayanB
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Add rectangle ui tool bar Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add rectangle draw mode similar to Polygon.
Issues Resolved
#213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screen.Recording.2023-03-14.at.10.24.55.PM.mov