Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor delete layer modal #242

Merged

Conversation

VijayanB
Copy link
Member

Description

Move delete layer modal into different component and added test.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #242 (c87c8cc) into main (ffb12e6) will increase coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   91.60%   91.66%   +0.06%     
==========================================
  Files           9       10       +1     
  Lines         262      264       +2     
  Branches       34       34              
==========================================
+ Hits          240      242       +2     
  Misses         16       16              
  Partials        6        6              
Impacted Files Coverage Δ
...ponents/layer_control_panel/delete_layer_modal.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -30,6 +30,7 @@
"wellknown": "^0.5.0"
},
"devDependencies": {
"@types/react-test-renderer": "^18.0.0",
Copy link
Member

@junqiu-lei junqiu-lei Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why we need import this dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VijayanB VijayanB merged commit c688c23 into opensearch-project:main Feb 13, 2023
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-242-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c688c23f37ee1fc33f1f5e5af685236bb1475f3b
# Push it to GitHub
git push --set-upstream origin backport/backport-242-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-242-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Vijayan Balasubramanian <[email protected]>
(cherry picked from commit c688c23)
junqiu-lei pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Vijayan Balasubramanian <[email protected]>
(cherry picked from commit c688c23)

Co-authored-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants