-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor delete layer modal #242
Refactor delete layer modal #242
Conversation
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 91.60% 91.66% +0.06%
==========================================
Files 9 10 +1
Lines 262 264 +2
Branches 34 34
==========================================
+ Hits 240 242 +2
Misses 16 16
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -30,6 +30,7 @@ | |||
"wellknown": "^0.5.0" | |||
}, | |||
"devDependencies": { | |||
"@types/react-test-renderer": "^18.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why we need import this dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean where is this used in my test?
https://github.com/opensearch-project/dashboards-maps/pull/242/files#diff-a541d7c1c45c0863a23f2597da09b9770059d8686cff659d192b4447bdaffee1R9
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-242-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c688c23f37ee1fc33f1f5e5af685236bb1475f3b
# Push it to GitHub
git push --set-upstream origin backport/backport-242-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit c688c23)
Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit c688c23) Co-authored-by: Vijayan Balasubramanian <[email protected]>
Description
Move delete layer modal into different component and added test.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.