Refactor layer properties as own interface #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vijayan Balasubramanian <[email protected]>
junqiu-lei
reviewed
Feb 3, 2023
public/model/map/layer_operations.ts
Outdated
| @@ -48,16 +48,19 @@ export const updateLayerVisibility = (map: Maplibre, layerId: string, visibility | |||
| }); | |||
| }; | |||
|
|
|||
| export interface LineLayerSpecification { | |||
| export interface Layer { | |||
There was a problem hiding this comment.
Shall we name it mbLayer or add some comment here to explain it's the layer in maplibre? Because there are two layers conception: maps dashboards layer and maplibre layer
There was a problem hiding this comment.
Made it local and added comment. This layer is an abstraction between Dashboard and Maplibre.
Create layer interface to abstract common properties. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
changed the title
junqiu-lei
approved these changes
Feb 3, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-225-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e40617e17d943765a1f580c3fdbecaf66c9b7179
# Push it to GitHub
git push --set-upstream origin backport/backport-225-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Remove unused methods * Create layer interface to abstract common properties. Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit e40617e)
VijayanB
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Remove unused methods * Create layer interface to abstract common properties. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused methods
Refactor common properties
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.