Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor layer operations #224

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Conversation

VijayanB
Copy link
Member

Description

Refactor following layer operations

  1. getLayer
  2. hasLayer
  3. removeLayer
  4. moveLayer
  5. updateVisibility

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB requested a review from a team January 31, 2023 04:07
@VijayanB VijayanB self-assigned this Jan 31, 2023
Signed-off-by: Vijayan Balasubramanian <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #224 (7f2c795) into main (535a002) will increase coverage by 3.66%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   87.42%   91.09%   +3.66%     
==========================================
  Files           6        7       +1     
  Lines         175      247      +72     
  Branches       24       33       +9     
==========================================
+ Hits          153      225      +72     
  Misses         16       16              
  Partials        6        6              
Impacted Files Coverage Δ
...Dashboards/plugins/dashboards-maps/common/index.ts 100.00% <0.00%> (ø)
...shboards-maps/public/model/map/layer_operations.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB merged commit ab56667 into opensearch-project:main Feb 1, 2023
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-224-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab56667adaa34cf8e8b894fe00130cf8c90f93e9
# Push it to GitHub
git push --set-upstream origin backport/backport-224-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-224-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 10, 2023
* Add layer as constructor parameter
* Refactor get/has layer
* Refactor remove layer
* Refactor visibility property
* Rename visibility layer

Signed-off-by: Vijayan Balasubramanian <[email protected]>
(cherry picked from commit ab56667)
VijayanB pushed a commit that referenced this pull request Feb 13, 2023
* Add layer as constructor parameter
* Refactor get/has layer
* Refactor remove layer
* Refactor visibility property
* Rename visibility layer

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants