Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add layer operations #222

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Conversation

VijayanB
Copy link
Member

Description

Move add layers from document layer to own file. Added unit test.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB requested a review from a team January 30, 2023 06:14
@VijayanB VijayanB self-assigned this Jan 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #222 (84b518c) into main (bb947ed) will increase coverage by 2.54%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   87.50%   90.04%   +2.54%     
==========================================
  Files           6        7       +1     
  Lines         176      221      +45     
  Branches       24       27       +3     
==========================================
+ Hits          154      199      +45     
  Misses         16       16              
  Partials        6        6              
Impacted Files Coverage Δ
...shboards-maps/public/model/map/layer_operations.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VijayanB
Copy link
Member Author

Build failure will be fixed after merging this: opensearch-project/geospatial#210

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB merged commit 538628c into opensearch-project:main Jan 31, 2023
@VijayanB VijayanB deleted the unit-test branch January 31, 2023 03:59
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2023
* Refactor add geoshape layers outside document layer
* Update layer opeartions
* Add unit test

Signed-off-by: Vijayan Balasubramanian <[email protected]>
(cherry picked from commit 538628c)
VijayanB added a commit to VijayanB/dashboards-maps that referenced this pull request Feb 8, 2023
* Refactor add geoshape layers outside document layer
* Update layer opeartions
* Add unit test

Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB added a commit that referenced this pull request Feb 10, 2023
* Refactor add geoshape layers outside document layer
* Update layer opeartions
* Add unit test

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants