Support overriding maps config from OSD config yml file #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
changed the title
Signed-off-by: Junqiu Lei <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 87.64% 87.42% -0.22%
==========================================
Files 6 6
Lines 178 175 -3
Branches 24 24
==========================================
- Hits 156 153 -3
Misses 16 16
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
navneet1v
approved these changes
Jan 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit b180af9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit b180af9)
junqiu-lei
added a commit
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit b180af9) Co-authored-by: Junqiu Lei <[email protected]>
junqiu-lei
added a commit
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit b180af9) Co-authored-by: Junqiu Lei <[email protected]>
VijayanB
reviewed
Jan 11, 2023
| @@ -23,9 +23,6 @@ export { | |||
| PLUGIN_NAME, | |||
| }; | |||
|
|
|||
| export const MAP_VECTOR_TILE_BASIC_STYLE = 'https://tiles.maps.opensearch.org/styles/basic.json'; | |||
| export const MAP_GLYPHS = 'https://tiles.maps.opensearch.org/fonts/{fontstack}/{range}.pbf'; | |||
There was a problem hiding this comment.
Why do we have to move font stack to config?
There was a problem hiding this comment.
It moved to config.ts with the default value so that the url can be overridden configured from OSD config url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei [email protected]
Description
Allow user to override maps service url configuration from OpenSearch-Dashboard config yml file by adding:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.