Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing CI workflow #174

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Jan 7, 2023

Description

Unblock existing CI workflows for both cypress test and unit test and add cypress test cases for new maps.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@junqiu-lei junqiu-lei requested a review from a team January 7, 2023 08:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #174 (c959e9a) into main (971c5a4) will increase coverage by 2.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   85.03%   87.50%   +2.46%     
==========================================
  Files           5        6       +1     
  Lines         147      176      +29     
  Branches       24       24              
==========================================
+ Hits          125      154      +29     
  Misses         16       16              
  Partials        6        6              
Impacted Files Coverage Δ
common/constants/shared.ts
common/util.ts
public/components/show_error_modal.tsx
public/components/vector_upload_options.tsx
public/services.ts
...s-maps/public/components/vector_upload_options.tsx 88.42% <0.00%> (ø)
...hboards/plugins/dashboards-maps/public/services.ts 20.00% <0.00%> (ø)
...Dashboards/plugins/dashboards-maps/common/index.ts 100.00% <0.00%> (ø)
...plugins/dashboards-maps/common/constants/shared.ts 100.00% <0.00%> (ø)
...boards-maps/public/components/show_error_modal.tsx 100.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vamshin
vamshin previously approved these changes Jan 7, 2023
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@navneet1v
Copy link
Collaborator

After fixing the cypress test why the ci is still failing? @junqiu-lei

@junqiu-lei
Copy link
Member Author

junqiu-lei commented Jan 7, 2023

After fixing the cypress test why the ci is still failing? @junqiu-lei

I think previously also have the similar issue. It will time out to find element. Just tried to increase wait time.

@junqiu-lei junqiu-lei changed the title Unblock existing CI workflow Update existing CI workflow Jan 8, 2023
@junqiu-lei junqiu-lei force-pushed the cypress_test branch 5 times, most recently from f3cd281 to f3f347a Compare January 9, 2023 15:51
Signed-off-by: Junqiu Lei <[email protected]>
@junqiu-lei
Copy link
Member Author

junqiu-lei commented Jan 9, 2023

Cypress tests passed at Ubuntu OS:

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  documentsLayer.spec.js                   01:48        2        2        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  geojson_file_upload.spec.js              01:26        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  import_vector_map_tab.spec.js            01:22        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  opensearchMapLayer.spec.js               01:40        1        1        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        06:18        5        5        -        -        -  

https://github.com/opensearch-project/dashboards-maps/actions/runs/3876804010/jobs/6611075511

opensearchMapLayer.spec.js.mp4
documentsLayer.spec.js.mp4

The first three cypress tests failed on Windows OS:

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✖  documentsLayer.spec.js                   01:04        2        -        1        -        1 │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  geojson_file_upload.spec.js              01:04        1        -        1        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  import_vector_map_tab.spec.js            01:04        1        -        1        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  opensearchMapLayer.spec.js               02:15        1        1        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✖  3 of 4 failed (75%)                      05:27        5        1        3        -        1  

The reason for the Windows failed is the OSD server loading time is too long to start, only util to the last test, it started. Will need to add logic on retry failed activity.

@navneet1v
Copy link
Collaborator

@junqiu-lei lets fix the windows platform tests too.

@junqiu-lei
Copy link
Member Author

@junqiu-lei lets fix the windows platform tests too.

Yes

@junqiu-lei junqiu-lei merged commit b75cf16 into opensearch-project:main Jan 9, 2023
@junqiu-lei junqiu-lei deleted the cypress_test branch January 9, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants