-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update existing CI workflow #174
Conversation
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 85.03% 87.50% +2.46%
==========================================
Files 5 6 +1
Lines 147 176 +29
Branches 24 24
==========================================
+ Hits 125 154 +29
Misses 16 16
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
34962f3
to
eb186ef
Compare
After fixing the cypress test why the ci is still failing? @junqiu-lei |
eb186ef
to
6c0e7be
Compare
I think previously also have the similar issue. It will time out to find element. Just tried to increase wait time. |
f3cd281
to
f3f347a
Compare
Signed-off-by: Junqiu Lei <[email protected]>
f3f347a
to
638a765
Compare
Cypress tests passed at Ubuntu OS:
opensearchMapLayer.spec.js.mp4documentsLayer.spec.js.mp4The first three cypress tests failed on Windows OS:
The reason for the Windows failed is the OSD server loading time is too long to start, only util to the last test, it started. Will need to add logic on retry failed activity. |
@junqiu-lei lets fix the windows platform tests too. |
Yes |
Description
Unblock existing CI workflows for both cypress test and unit test and add cypress test cases for new maps.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.