Refactor geospatial style layer #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add circle/line/fill maplibre once per geo_shape. Signed-off-by: Vijayan Balasubramanian <[email protected]>
|
I see a lot of functions being updated, do these functions have existing unit tests associated with them? If not can we add some? |
|
@ashwin-pc It is strange that it shows like i made lot of change. Actually, i just moved block inside if and else as two methods and calling out directly. We don't have existing unit test, we will be creating unit test for all layer functions starting day after tomm ( will only merge into main after acceptable test coverage), in the meantime we are doing manual testing. |
junqiu-lei
approved these changes
Jan 4, 2023
|
@VijayanB Thanks for the context, that sounds good to me! |
martin-gaievski
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add circle/line/fill maplibre once per geo_shape.
Signed-off-by: Vijayan Balasubramanian [email protected]
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.