Improve UX #142

VijayanB · 2022-12-23T03:07:37Z

Description

Set new layer name as New layer
Set default OpenSearch Map as "Default map"
Added tooltip for buttons
Layer type icon is added before title

Demo
Icons are updated as below and updated layer names

Add layer panel

Layer type Icon is added before tile

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

junqiu-lei · 2022-12-23T18:28:04Z

maps_dashboards/public/components/layer_control_panel/layer_control_panel.tsx

@@ -301,7 +301,7 @@ export const LayerControlPanel = memo(
                              <EuiFlexItem>
                                <EuiListGroupItem
                                  key={layer.id}
-                                  label={layer.name}
+                                  label={layer.name || layersTypeNameMap[layer.type]}


For pending new layer, how about name "New " + layersTypeNameMap[layer.type]

Synced with Vijay, let's have input from UX here

Updated new layer name as New layer

junqiu-lei · 2022-12-28T01:00:43Z

maps_dashboards/public/components/add_layer_panel/add_layer_panel.tsx


  function onClickAddNewLayer(layerType: string) {
    const initLayerConfig = getLayerConfigMap()[layerType];
+    initLayerConfig.name = 'New layer ' + nextLayerIndex;


How about use layers.length + 1 for the new layer number? The nextLayerIndex will keep increasing even if I create a new layer but discard it.

Sure. But i don't think we have access to total layer inside Add layer panel, if not, how to get layer count without adding new dependency? or else, i have to move inside layer_control_panel. Let me see how does it look if i move it inside add_layer()

We can create a function in LayerControlPanel and pass it to AddLayerPanel which can help get new layer index from layers.

const getNewLayerIndex = () => { return layers.length + 1; };

I got error message from initLayerConfig.name = 'New layer ' + nextLayerIndex;, we might need to change not use enum for DASHBOARDS_MAPS_LAYER_NAME
TS2322: Type 'string' is not assignable to type 'DASHBOARDS_MAPS_LAYER_NAME'.

kept default value as empty string.

junqiu-lei · 2022-12-28T01:02:57Z

maps_dashboards/public/model/layersFunctions.ts

@@ -4,7 +4,7 @@
 */

 import { Map as Maplibre } from 'maplibre-gl';
-import { DASHBOARDS_MAPS_LAYER_NAME, DASHBOARDS_MAPS_LAYER_TYPE } from '../../common';
+import { DASHBOARDS_MAPS_LAYER_ICON, DASHBOARDS_MAPS_LAYER_NAME, DASHBOARDS_MAPS_LAYER_TYPE } from "../../common";


Suggested change

import { DASHBOARDS_MAPS_LAYER_ICON, DASHBOARDS_MAPS_LAYER_NAME, DASHBOARDS_MAPS_LAYER_TYPE } from "../../common";

import {

DASHBOARDS_MAPS_LAYER_ICON,

DASHBOARDS_MAPS_LAYER_NAME,

DASHBOARDS_MAPS_LAYER_TYPE,

} from '../../common';

vamshin · 2022-12-28T01:24:01Z

maps_dashboards/public/components/tooltip/tooltipTable.tsx

@@ -153,7 +156,7 @@ const TooltipTable = ({
      </EuiFlexGroup>
      <EuiSpacer size="s" />
      <EuiFlexGroup justifyContent="spaceAround" alignItems="center" gutterSize="none">
-        {showLayerSelection && (
+        {showLayerSelection && options?.length > 1 && (


Should this be >=1?

I think we need layer selection only if there are more than 1 layer.

junqiu-lei · 2022-12-28T18:22:41Z

Shall we also update the layer name to "Default map" at add new layer modal?

VijayanB · 2022-12-28T22:17:02Z

Shall we also update the layer name to "Default map" at add new layer modal?

Default map is layer name for default layer created by Maps. We don't have to rename OpenSearch Map as default map since in future we might allow users to customize this default layer.

maps_dashboards/public/components/add_layer_panel/add_layer_panel.tsx

maps_dashboards/public/components/layer_config/layer_config_panel.tsx

Signed-off-by: Vijayan Balasubramanian <[email protected]>

Set new layer name as New layer Set default OpenSearch Map as "Default map" Added tooltip for buttons Layer type icon is added before title Signed-off-by: Vijayan Balasubramanian <[email protected]>

Show layer selection only if more than 1 layers are available. Signed-off-by: Vijayan Balasubramanian <[email protected]>

Signed-off-by: Vijayan Balasubramanian <[email protected]>

VijayanB requested a review from a team December 23, 2022 03:07

VijayanB self-assigned this Dec 23, 2022

VijayanB force-pushed the improve-ux branch 5 times, most recently from 8bacaad to 32f8002 Compare December 23, 2022 07:42

junqiu-lei reviewed Dec 23, 2022

View reviewed changes

junqiu-lei previously approved these changes Dec 23, 2022

View reviewed changes

VijayanB dismissed junqiu-lei’s stale review via 15ed998 December 24, 2022 00:33

VijayanB force-pushed the improve-ux branch from 32f8002 to 15ed998 Compare December 24, 2022 00:33

VijayanB changed the title ~~Set default name as empty for new layer and disable tooltip~~ Improve UX Dec 28, 2022

VijayanB force-pushed the improve-ux branch from 15ed998 to 7b6a0a4 Compare December 28, 2022 00:17

VijayanB requested a review from junqiu-lei December 28, 2022 00:29

VijayanB force-pushed the improve-ux branch 2 times, most recently from dc12ace to d9eff11 Compare December 28, 2022 00:38

junqiu-lei reviewed Dec 28, 2022

View reviewed changes

VijayanB force-pushed the improve-ux branch from 7a7d212 to 6ece4a6 Compare December 28, 2022 01:10

VijayanB requested a review from junqiu-lei December 28, 2022 01:11

vamshin reviewed Dec 28, 2022

View reviewed changes

VijayanB force-pushed the improve-ux branch from 6ece4a6 to 2ca1f9e Compare December 28, 2022 01:41

VijayanB requested a review from vamshin December 28, 2022 01:45

VijayanB force-pushed the improve-ux branch 2 times, most recently from 298c475 to d95af64 Compare December 28, 2022 02:48

junqiu-lei previously approved these changes Dec 29, 2022

View reviewed changes

VijayanB dismissed junqiu-lei’s stale review via 0bfce59 December 29, 2022 19:03

VijayanB force-pushed the improve-ux branch from 643cd5d to 0bfce59 Compare December 29, 2022 19:03

VijayanB force-pushed the improve-ux branch from 0bfce59 to a257c6d Compare December 29, 2022 20:33

junqiu-lei previously approved these changes Dec 29, 2022

View reviewed changes

heemin32 reviewed Dec 29, 2022

View reviewed changes

VijayanB dismissed junqiu-lei’s stale review via 0e34835 December 29, 2022 23:28

VijayanB force-pushed the improve-ux branch from a257c6d to 0e34835 Compare December 29, 2022 23:28

VijayanB added 4 commits December 29, 2022 15:29

Remove rendering after loading

e83d213

Signed-off-by: Vijayan Balasubramanian <[email protected]>

Improve UX

7e92603

Set new layer name as New layer Set default OpenSearch Map as "Default map" Added tooltip for buttons Layer type icon is added before title Signed-off-by: Vijayan Balasubramanian <[email protected]>

Show layer selection selectively

5426927

Show layer selection only if more than 1 layers are available. Signed-off-by: Vijayan Balasubramanian <[email protected]>

Allow only single layer selection

9f0f24e

Signed-off-by: Vijayan Balasubramanian <[email protected]>

VijayanB force-pushed the improve-ux branch from 0e34835 to 9f0f24e Compare December 29, 2022 23:29

Fixed code review comments

4fc50e5

Signed-off-by: Vijayan Balasubramanian <[email protected]>

VijayanB requested review from heemin32 and junqiu-lei December 29, 2022 23:32

junqiu-lei approved these changes Dec 29, 2022

View reviewed changes

heemin32 approved these changes Dec 30, 2022

View reviewed changes

VijayanB merged commit ccfe171 into opensearch-project:feature/new-maps Dec 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve UX #142

Improve UX #142

VijayanB commented Dec 23, 2022 •

edited

Loading

junqiu-lei Dec 23, 2022

junqiu-lei Dec 23, 2022

VijayanB Dec 28, 2022

junqiu-lei Dec 28, 2022

VijayanB Dec 28, 2022 •

edited

Loading

junqiu-lei Dec 28, 2022 •

edited

Loading

junqiu-lei Dec 28, 2022

VijayanB Dec 28, 2022

junqiu-lei Dec 28, 2022

VijayanB Dec 28, 2022

vamshin Dec 28, 2022

VijayanB Dec 28, 2022 •

edited

Loading

junqiu-lei commented Dec 28, 2022

VijayanB commented Dec 28, 2022 •

edited

Loading

Improve UX #142

Improve UX #142

Conversation

VijayanB commented Dec 23, 2022 • edited Loading

Description

Issues Resolved

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VijayanB Dec 28, 2022 • edited Loading

Choose a reason for hiding this comment

junqiu-lei Dec 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VijayanB Dec 28, 2022 • edited Loading

Choose a reason for hiding this comment

junqiu-lei commented Dec 28, 2022

VijayanB commented Dec 28, 2022 • edited Loading

VijayanB commented Dec 23, 2022 •

edited

Loading

VijayanB Dec 28, 2022 •

edited

Loading

junqiu-lei Dec 28, 2022 •

edited

Loading

VijayanB Dec 28, 2022 •

edited

Loading

VijayanB commented Dec 28, 2022 •

edited

Loading