feat: added multi-layer support to map popup #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
reviewed
Dec 22, 2022
| @@ -104,7 +104,7 @@ const LayerControlPanel = memo(({ maplibreRef, setLayers, layers }: Props) => { | |||
| if (isCompleteResponse(response)) { | |||
| const dataSource = response.rawResponse.hits.hits; | |||
| layersFunctionMap[layer.type].render(maplibreRef, layer, dataSource); | |||
| layersFunctionMap[layer.type].addTooltip(maplibreRef, layer); | |||
| // layersFunctionMap[layer.type].addTooltip(maplibreRef, layer); | |||
There was a problem hiding this comment.
Shall we remove this line if not need?
1. Abstract a reusable popup rendering logic. 2. For click-popups which need to display multi-layers information, added an event listener globally and then query features from all layers at the current position. 3. For hover-popups which show information of the current layer features, moved the popup rendering logic out from the layer render logic(in the layer control panel component). Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
feature/new-maps-tooltip-improvement
branch
from
7f1c741 to
97987be
Compare
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
feature/new-maps-tooltip-improvement
branch
from
670bac5 to
b5f358a
Compare
junqiu-lei
approved these changes
Dec 23, 2022
VijayanB
approved these changes
Dec 23, 2022
junqiu-lei
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor map popup rendering logic,
Signed-off-by: Yulong Ruan [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.