Add global time filter bar to maps #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin-pc
reviewed
Dec 20, 2022
maps_dashboards/public/components/map_container/map_container.scss
Outdated
Show resolved
Hide resolved
Probably global filter bar is better tittle? This PR mainly for time filters. |
junqiu-lei
changed the title
junqiu-lei
force-pushed
the
query_bar
branch
from
a908ef8 to
1b76052
Compare
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
query_bar
branch
from
1b76052 to
6bdb462
Compare
VijayanB
approved these changes
Dec 22, 2022
heemin32
approved these changes
Dec 22, 2022
ruanyl
reviewed
Dec 23, 2022
|
|
||
| useEffect(() => { | ||
| if (mapIdFromUrl) { | ||
| savedObjectsClient.get<MapSavedObjectAttributes>('map', mapIdFromUrl).then((res) => { | ||
| setSavedMapObject(res); | ||
| setLayers(JSON.parse(res.attributes.layerList as string)); | ||
| const layerList: MapLayerSpecification[] = JSON.parse(res.attributes.layerList as string); | ||
| const savedMapState: MapState = JSON.parse(res.attributes.mapState as string); |
There was a problem hiding this comment.
Type casting is potentially dangerous for runtime, I got a runtime error on this line because I have previously created map which mapState is undefined
There was a problem hiding this comment.
@ruanyl Thanks call out here! I think previously in your local code commit, there didn't have mapState. Currently for all initially created maps, it will have mapState property to the map saved object.
junqiu-lei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei [email protected]
Description
This PR is for global filter bar which can be used to filter timeline for all indexPatterns.
Demo
Screen.Recording.2022-12-21.at.2.51.11.PM.mov
Issues Resolved
#103
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.