Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display search filters in map layer config panel #130

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Dec 20, 2022

Adding filters to map layer which allows user to do more accurate and customized searches

Signed-off-by: Yulong Ruan [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Adding filters to map layer allows user to do more accurate and
customized searches

Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl ruanyl requested a review from a team December 20, 2022 09:38
@junqiu-lei
Copy link
Member

Great thanks @ruanyl, I just found one warning message for this PR code on my local console when I input boolean value on my local.

reproduce:

image

Warning: Failed prop type: Invalid prop `value` supplied to `EuiSelect`, expected one of type [string, number].
    in EuiSelect (created by ValueInputTypeUI)
    in ValueInputTypeUI (created by InjectIntl(ValueInputTypeUI))
    in InjectIntl(ValueInputTypeUI) (created by PhraseValueInputUI)
    ......

Co-authored-by: Junqiu Lei <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl
Copy link
Member Author

ruanyl commented Dec 21, 2022

@junqiu-lei nice catch on the EuiSelect warning! But it looks like it's Eui related, it actually happen to EuiSelect component on other places as well, like on Discover page, when you add the same filter, you could see the same warning(to see the warning, try to refresh the page and start from scratch).

@ruanyl ruanyl requested a review from junqiu-lei December 21, 2022 01:07
Copy link
Member

@junqiu-lei junqiu-lei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@VijayanB VijayanB merged commit e5e2f2a into opensearch-project:feature/new-maps Dec 21, 2022
@junqiu-lei junqiu-lei added feature v2.5.0 'Issues and PRs related to version v2.5.0' labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants