Update show/hide icon #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When layer is visible, you will see eye closed icon on layer panel, next to layer name. This shows that you can hide layer by clicking this button ( eyeClosed )
When layer is hidden, you will see eye (opened) icon on layer panel, next to layer name. This shows that you can show layer by clicking this button ( eyeClosed )
In following up PR, we will add tool tip to all buttons. |
VijayanB
force-pushed
the
eye
branch
4 times, most recently
from
115e792 to
868c253
Compare
junqiu-lei
reviewed
Dec 8, 2022
| @@ -140,6 +143,12 @@ const LayerControlPanel = memo(({ maplibreRef, setLayers, layers }: Props) => { | |||
| setIsLayerConfigVisible(true); | |||
| }; | |||
|
|
|||
| const [layerVisiblity, setLayerVisibility] = useState(new Map()); | |||
| layers.forEach((layer) => { | |||
| layerVisiblity.set(layer.id, layer.visibility == LAYER_VISIBILITY.VISIBLE); | |||
There was a problem hiding this comment.
Suggested change
| layerVisiblity.set(layer.id, layer.visibility == LAYER_VISIBILITY.VISIBLE); | |
| layerVisiblity.set(layer.id, layer.visibility === LAYER_VISIBILITY.VISIBLE); |
| @@ -140,6 +143,12 @@ const LayerControlPanel = memo(({ maplibreRef, setLayers, layers }: Props) => { | |||
| setIsLayerConfigVisible(true); | |||
| }; | |||
|
|
|||
| const [layerVisiblity, setLayerVisibility] = useState(new Map()); | |||
There was a problem hiding this comment.
Typo: layerVisibility
Can we define the type to the Map?
useState(new Map<string, boolean>([]))
Based on action eye closed or eye icon will be displayed. Signed-off-by: Vijayan Balasubramanian <[email protected]>
junqiu-lei
approved these changes
Dec 8, 2022
martin-gaievski
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on hide/show layer available, eye closed or eye icon will be displayed.
Signed-off-by: Vijayan Balasubramanian [email protected]
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.