Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic layer settings #107

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Dec 6, 2022

Description

Include following fields to basic layer settings

  • Type : to show layer type, ex: Documents, OpenSearch Map, Custom Map, etc ...
  • Description: to accept more than one to describe layer description
  • Rename to Zoom levels

Signed-off-by: Vijayan Balasubramanian [email protected]

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Include type to layer basic settings.
Added function to map layer type to name, since,
user is interested in name.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB requested a review from a team December 6, 2022 06:19
@VijayanB
Copy link
Member Author

VijayanB commented Dec 6, 2022

Screen Shot 2022-12-05 at 10 55 30 PM
Screen Shot 2022-12-05 at 10 55 40 PM

@VijayanB VijayanB self-assigned this Dec 6, 2022
@VijayanB VijayanB added v2.5.0 'Issues and PRs related to version v2.5.0' maps labels Dec 6, 2022
Added text area to accept description.
Added properties to save description.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB changed the title Add type to layer settings Update basic layer settings Dec 6, 2022
Rename Zoom text to Zoom levels on display

Signed-off-by: Vijayan Balasubramanian <[email protected]>
import { OSMLayerFunctions } from './OSMLayerFunctions';
import { DocumentLayerFunctions } from './documentLayerFunctions';

export const layersFunctionMap: { [key: string]: any } = {
[DASHBOARDS_MAPS_LAYER_TYPE.OPENSEARCH_MAP]: OSMLayerFunctions,
[DASHBOARDS_MAPS_LAYER_TYPE.DOCUMENTS]: DocumentLayerFunctions,
};

export const layersTypeNameMap: { [key: string]: any } = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const layersTypeNameMap: { [key: string]: any } = {
export const layersTypeNameMap: { [key: string]: string } = {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB requested a review from junqiu-lei December 6, 2022 17:46
Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thx!

@VijayanB VijayanB merged commit 1a40ef5 into opensearch-project:feature/new-maps Dec 6, 2022
@junqiu-lei junqiu-lei added the enhancement New feature or request label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maps v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants