feat: integrate regenerate API #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #58 +/- ##
===========================================================
+ Coverage 48.75% 58.67% +9.91%
===========================================================
Files 46 46
Lines 1087 1089 +2
Branches 250 252 +2
===========================================================
+ Hits 530 639 +109
+ Misses 548 441 -107
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Hailong-am
reviewed
Dec 11, 2023
server/routes/chat_routes.ts
Outdated
| /** | ||
| * Retrieve latest interactions from memory | ||
| */ | ||
| const sessionId = sessionIdInRequestBody; |
There was a problem hiding this comment.
can we rename sessionIdInRequestBody to sessionId?
Signed-off-by: SuZhou-Joe <[email protected]>
ruanyl
approved these changes
Dec 12, 2023
| question?: string; | ||
| verbose?: boolean; | ||
| memory_id?: string; | ||
| } = { |
There was a problem hiding this comment.
What about define an interface AgentRunPayload and then reuse it on L19, L85, L106 so we don't need to define inline types repeatedly.
interface AgentRunPayload {
question?: string;
verbose?: boolean;
memory_id?: string;
regenerate_interaction_id?: string;
}Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
merged commit 11e5779
into
opensearch-project:feature/agent-framework
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the implementation of regenerate from langchain to Agent framework.
Backend API reference: opensearch-project/ml-commons#1709
Before regenerate:
Regenrating:
After regenerate:
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.