Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrect message id field used #378

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Dec 18, 2024

ml-commons changed the agent execution response { name: 'parent_interaction_id' } to { name: 'parent_message_id' } for conversational_flow type of agent.
This commit update the fields used at FE to make it work for both case.

Description

[Describe what this change achieves]

Issues Resolved

resolved #377

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ml-commons changed the agent execution response { name:
'parent_interaction_id' } to { name: 'parent_message_id' }
for conversational_flow type of agent.
This commit update the fields used at FE to make it work for both case.

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl ruanyl merged commit faa409f into opensearch-project:main Dec 26, 2024
9 checks passed
raintygao pushed a commit to raintygao/dashboards-assistant that referenced this pull request Jan 22, 2025
* fixed incorrect message id field used

ml-commons changed the agent execution response { name:
'parent_interaction_id' } to { name: 'parent_message_id' }
for conversational_flow type of agent.
This commit update the fields used at FE to make it work for both case.

Signed-off-by: Yulong Ruan <[email protected]>

* add changelog entry

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl ruanyl added the backport 2.x Trigger the backport flow to 2.x label Feb 8, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 8, 2025
* fixed incorrect message id field used

ml-commons changed the agent execution response { name:
'parent_interaction_id' } to { name: 'parent_message_id' }
for conversational_flow type of agent.
This commit update the fields used at FE to make it work for both case.

Signed-off-by: Yulong Ruan <[email protected]>

* add changelog entry

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit faa409f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ruanyl pushed a commit that referenced this pull request Feb 10, 2025
* fixed incorrect message id field used

ml-commons changed the agent execution response { name:
'parent_interaction_id' } to { name: 'parent_message_id' }
for conversational_flow type of agent.
This commit update the fields used at FE to make it work for both case.

Signed-off-by: Yulong Ruan <[email protected]>

* add changelog entry

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit faa409f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error shows up with "InteractionId is required"
3 participants